feat: hide activity types that don't exist in project [IN-751]#733
Merged
borfast merged 1 commit intoOct 15, 2025
Merged
Conversation
borfast
force-pushed
the
feat/IN-751-hide-activity-types-that-dont-exist-in-project
branch
5 times, most recently
from
d8cb3aa to
2de67d6
Compare
borfast
force-pushed
the
feat/IN-751-hide-activity-types-that-dont-exist-in-project
branch
from
2de67d6 to
72fe8a3
Compare
gaspergrom
requested changes
Oct 13, 2025
| const projectSlug = computed(() => project.value?.slug || ''); | ||
|
|
||
| // Fetch activity types from Tinybird | ||
| const { data: activityTypesData } = await useFetch(() => { |
Collaborator
There was a problem hiding this comment.
use useQuery from tanstack for this
Contributor
Author
There was a problem hiding this comment.
I changed it to the best of my knowledge. I have 0 experience with Tanstack, so please have a look to see if there's anything done incorrectly.
borfast
force-pushed
the
feat/IN-751-hide-activity-types-that-dont-exist-in-project
branch
from
72fe8a3 to
59cc5c7
Compare
borfast
changed the base branch from
main
to
feat/in-511-provide-new-endpoint-with-available-activity-types
borfast
force-pushed
the
feat/IN-751-hide-activity-types-that-dont-exist-in-project
branch
from
59cc5c7 to
369758e
Compare
borfast
force-pushed
the
feat/IN-751-hide-activity-types-that-dont-exist-in-project
branch
from
369758e to
9788948
Compare
borfast
force-pushed
the
feat/in-511-provide-new-endpoint-with-available-activity-types
branch
from
ebf69cb to
0d69666
Compare
borfast
force-pushed
the
feat/IN-751-hide-activity-types-that-dont-exist-in-project
branch
from
9788948 to
3b0df28
Compare
borfast
changed the base branch from
feat/in-511-provide-new-endpoint-with-available-activity-types
to
main
gaspergrom
approved these changes
Oct 15, 2025
Signed-off-by: Raúl Santos <4837+borfast@users.noreply.github.com> feat: provide a new endpoint with available activity types Signed-off-by: Raúl Santos <4837+borfast@users.noreply.github.com>
borfast
force-pushed
the
feat/IN-751-hide-activity-types-that-dont-exist-in-project
branch
from
3b0df28 to
facd854
Compare
borfast
deleted the
feat/IN-751-hide-activity-types-that-dont-exist-in-project
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the widgets that currently support filtering by activity type (see image below for an example), we want to change the available options, so that activity types that do not exist for the displayed project are not shown as filter options.
This is hard-coded in the platform config files here.
We want to change this so that only activity types that exist for the given project are shown - i.e. if a project has no github issues, this activity type should not be displayed in the dropdown as a filtering option.
In this PR we:
Since the activity types from the platforms config files are not necessary or even wanted anymore, they are also being removed.
This depends on my two other related PRs from crowd.dev to be merged and deployed first (3488 and 3489).
Jira tickets:
These were initially two separate PRs but to avoid some issues and make it easier to review (despite this way having more files in a single PR) I merged them into a single one, and so I'm closing #745 in favour of this one.
main