added all the metrics for the activity dropdown#98
Conversation
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
|
Caution Review failedThe pull request is closed. WalkthroughThis update restructures the metrics configuration in the frontend and includes a minor adjustment in the dropdown settings. The Changes
Possibly related PRs
Suggested reviewers
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
frontend/app/components/modules/project/components/contributors/active-contributors.vue (1)
124-124: Remove console.log statement before production deploymentConsole logging statements should typically be removed before merging to production code as they can clutter the browser console and potentially expose information.
watch(selectedTimeRangeKey, () => { activeTab.value = tabs.value[0]?.value || 'weekly'; - console.log('activeTab', activeTab.value); });
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
frontend/app/components/modules/project/components/contributors/active-contributors.vue(2 hunks)frontend/app/components/modules/project/components/contributors/active-organizations.vue(1 hunks)
🔇 Additional comments (2)
frontend/app/components/modules/project/components/contributors/active-organizations.vue (1)
75-75: Default granularity changed from first to second optionThis change sets the default granularity to the second tab option instead of the first one. This matches the change in active-contributors.vue, ensuring consistent behavior across components.
Could you verify this change is intentional and aligns with the PR objective of enhancing the Activity dropdown? What specific granularity value does this now default to (assuming granularityTabs[1] is 'weekly')?
frontend/app/components/modules/project/components/contributors/active-contributors.vue (1)
75-75: Default granularity changed from first to second optionThis change sets the default granularity to the second tab option instead of the first one. This matches the change in active-organizations.vue, ensuring consistent behavior across components.
Signed-off-by: emlimlf <52259294+emlimlf@users.noreply.github.com>
|
|
||
| watch(selectedTimeRangeKey, () => { | ||
| activeTab.value = tabs.value[0]?.value || 'weekly'; | ||
| console.log('activeTab', activeTab.value); |
There was a problem hiding this comment.
Looks like this one got left behind.
| { label: 'Pull Requests Merged', value: 'pull-requests-merged' }, | ||
| { label: 'Pull Requests Reviews', value: 'pull-requests-reviews' }, | ||
| { label: 'Pull Requests Comments', value: 'pull-requests-comments' } | ||
| export const metricsOptions: DropdownGroupOptions[] = [ |
There was a problem hiding this comment.
Do we have a bit of a mismatch in terms of language here? We talk about "activities" but we're calling them "metrics" in the code, which can be a little confusing. A metric would be the number of a thing, not the thing itself. And we are filtering by the thing, not its number. Does that make sense, or am I mixing things?
| @@ -1,13 +1,378 @@ | |||
| import type { DropdownOption } from '~/components/uikit/dropdown/types/dropdown.types'; | |||
| import type { DropdownGroupOptions } from '~/components/uikit/dropdown/types/dropdown.types'; | |||
There was a problem hiding this comment.
This would be for a separate PR but, since the type DropdownGroupOptions (and the related DropdownOption) is specifically about activities and not just a generic dropdown widget, wouldn't it be better to name it something like ActivitiesDropdownGroupOptions, or something like that more explicit and less generic?
There was a problem hiding this comment.
No, DropdownGroupOptions is generic to the shared select component.
borfast
left a comment
borfast
left a comment
There was a problem hiding this comment.
There's a forgotten console.log() and I left a couple of questions regarding variable names.
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
3 participants
In this PR
Added all the activity types on the Activity dropdown shared component.
Ticket
INS-169
Future Work
Filter the activities shown in this dropdown to just the activities that are enabled for the specific project
Summary by CodeRabbit
New Features
Bug Fixes