Skip to content

Add /lfx-test-journey skill for multi-branch journey testing#6

Merged
niravpatel27 merged 2 commits intomainfrom
add-test-journey-skill
Mar 17, 2026
Merged

Add /lfx-test-journey skill for multi-branch journey testing#6
niravpatel27 merged 2 commits intomainfrom
add-test-journey-skill

Conversation

@niravpatel27
Copy link
Collaborator

Summary

  • Adds new /lfx-test-journey skill that combines feature branches from multiple repos into git worktrees for end-to-end journey testing
  • Interactive flow: discover repos → pick branches → create worktrees → merge → get cd + run commands
  • 6 subcommands: create, status, refresh, edit, teardown, list
  • Routes from /lfx entry point ("test a journey", "combine branches", etc.)
  • README updated with usage guide and skill documentation

Test plan

  • Verified skill loads and routes from /lfx entry point
  • Tested create flow end-to-end (repo discovery, branch selection, worktree creation, merge, manifest)
  • Tested teardown cleans up worktrees and branches
  • Verified conflict detection works correctly
  • Verified zsh compatibility (replaced ls -d glob with find)
  • Smoke tested all section headers, frontmatter, copyright headers

Copilot AI review requested due to automatic review settings March 17, 2026 17:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new /lfx-test-journey skill to support multi-repo, multi-branch “journey testing” by creating isolated git worktrees and managing them (create/status/refresh/edit/teardown), and wires it into the existing /lfx routing + documentation.

Changes:

  • Document /lfx-test-journey in README.md (skill list, overview table, usage guide, workflow diagram, project structure).
  • Extend the /lfx router skill documentation to route journey-testing intents to /lfx-test-journey.
  • Add a new lfx-test-journey/SKILL.md defining the interactive workflow and subcommands.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.

File Description
README.md Adds /lfx-test-journey to the documented skill set, with usage + workflow details.
lfx/SKILL.md Updates routing examples/intents so /lfx can dispatch to /lfx-test-journey.
lfx-test-journey/SKILL.md Introduces the new skill specification for multi-branch worktree-based journey testing.
.gitignore Adds an ignore rule for docs/superpowers/.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 60 to 71
```
/lfx ← start here (plain-language entry point)
/lfx-coordinator
/lfx-research
/lfx-backend-builder
/lfx-ui-builder
/lfx-product-architect
/lfx-preflight
/lfx-pr-catchup
/lfx-setup
/lfx-test-journey
```
Comment on lines +104 to +126
```bash
cd <repo-path>
# Get the git user name for filtering
GIT_USER=$(git config user.name)

# Find branches with recent work by this user, not yet merged to main
git log --author="$GIT_USER" --all --oneline --since='30 days ago' --format='%D' \
| tr ',' '\n' \
| sed 's/^ *//' \
| grep -E '^origin/' \
| sed 's|^origin/||' \
| grep -v '^main$' \
| grep -v '^HEAD$' \
| sort -u > /tmp/author_branches.txt

# Cross-reference with unmerged branches
git branch -r --no-merged main \
| sed 's|^ *origin/||' \
| sort -u > /tmp/unmerged_branches.txt

# Intersection: branches by user AND not merged
comm -12 /tmp/author_branches.txt /tmp/unmerged_branches.txt
```
| sort -u > /tmp/author_branches.txt

# Cross-reference with unmerged branches
git branch -r --no-merged main \
echo $HOME
```

Then use the `Write` tool with the **full absolute path**, e.g. `/Users/niravpatel/.lfx-journeys/<journey-name>/manifest.yaml` (NOT `~/.lfx-journeys/...`).
AskUserQuestion: "Journey name?"
```

Validate: no spaces (use hyphens), no special characters. Suggest a name based on common branch prefixes if possible, but always wait for the user's response.
New skill that combines feature branches from multiple repos into
git worktrees for end-to-end journey testing. Interactive flow:
discover repos, pick branches, create worktrees, merge, and get
exact cd + run commands.

6 subcommands: create, status, refresh, edit, teardown, list.
Routes from /lfx entry point. README updated with usage guide.

Signed-off-by: Nirav Patel <npatel@linuxfoundation.org>
@niravpatel27 niravpatel27 force-pushed the add-test-journey-skill branch from 4308936 to a92b0fb Compare March 17, 2026 17:33
- Remove hardcoded "8 skills" count from README
- Use mktemp for branch discovery temp files (avoid clobbering)
- Use origin/main instead of main in --no-merged (works without local ref)
- Replace hardcoded username in manifest path example with $HOME
- Reject / and .. in journey names (used in paths and branch names)

Signed-off-by: Nirav Patel <npatel@linuxfoundation.org>
@niravpatel27 niravpatel27 merged commit 72e13f8 into main Mar 17, 2026
1 check passed
@niravpatel27 niravpatel27 deleted the add-test-journey-skill branch March 17, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants