Add /lfx-test-journey skill for multi-branch journey testing#6
Merged
niravpatel27 merged 2 commits intomainfrom Mar 17, 2026
Merged
Add /lfx-test-journey skill for multi-branch journey testing#6niravpatel27 merged 2 commits intomainfrom
niravpatel27 merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new /lfx-test-journey skill to support multi-repo, multi-branch “journey testing” by creating isolated git worktrees and managing them (create/status/refresh/edit/teardown), and wires it into the existing /lfx routing + documentation.
Changes:
- Document
/lfx-test-journeyinREADME.md(skill list, overview table, usage guide, workflow diagram, project structure). - Extend the
/lfxrouter skill documentation to route journey-testing intents to/lfx-test-journey. - Add a new
lfx-test-journey/SKILL.mddefining the interactive workflow and subcommands.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| README.md | Adds /lfx-test-journey to the documented skill set, with usage + workflow details. |
| lfx/SKILL.md | Updates routing examples/intents so /lfx can dispatch to /lfx-test-journey. |
| lfx-test-journey/SKILL.md | Introduces the new skill specification for multi-branch worktree-based journey testing. |
| .gitignore | Adds an ignore rule for docs/superpowers/. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
60
to
71
| ``` | ||
| /lfx ← start here (plain-language entry point) | ||
| /lfx-coordinator | ||
| /lfx-research | ||
| /lfx-backend-builder | ||
| /lfx-ui-builder | ||
| /lfx-product-architect | ||
| /lfx-preflight | ||
| /lfx-pr-catchup | ||
| /lfx-setup | ||
| /lfx-test-journey | ||
| ``` |
Comment on lines
+104
to
+126
| ```bash | ||
| cd <repo-path> | ||
| # Get the git user name for filtering | ||
| GIT_USER=$(git config user.name) | ||
|
|
||
| # Find branches with recent work by this user, not yet merged to main | ||
| git log --author="$GIT_USER" --all --oneline --since='30 days ago' --format='%D' \ | ||
| | tr ',' '\n' \ | ||
| | sed 's/^ *//' \ | ||
| | grep -E '^origin/' \ | ||
| | sed 's|^origin/||' \ | ||
| | grep -v '^main$' \ | ||
| | grep -v '^HEAD$' \ | ||
| | sort -u > /tmp/author_branches.txt | ||
|
|
||
| # Cross-reference with unmerged branches | ||
| git branch -r --no-merged main \ | ||
| | sed 's|^ *origin/||' \ | ||
| | sort -u > /tmp/unmerged_branches.txt | ||
|
|
||
| # Intersection: branches by user AND not merged | ||
| comm -12 /tmp/author_branches.txt /tmp/unmerged_branches.txt | ||
| ``` |
lfx-test-journey/SKILL.md
Outdated
| | sort -u > /tmp/author_branches.txt | ||
|
|
||
| # Cross-reference with unmerged branches | ||
| git branch -r --no-merged main \ |
lfx-test-journey/SKILL.md
Outdated
| echo $HOME | ||
| ``` | ||
|
|
||
| Then use the `Write` tool with the **full absolute path**, e.g. `/Users/niravpatel/.lfx-journeys/<journey-name>/manifest.yaml` (NOT `~/.lfx-journeys/...`). |
lfx-test-journey/SKILL.md
Outdated
| AskUserQuestion: "Journey name?" | ||
| ``` | ||
|
|
||
| Validate: no spaces (use hyphens), no special characters. Suggest a name based on common branch prefixes if possible, but always wait for the user's response. |
New skill that combines feature branches from multiple repos into git worktrees for end-to-end journey testing. Interactive flow: discover repos, pick branches, create worktrees, merge, and get exact cd + run commands. 6 subcommands: create, status, refresh, edit, teardown, list. Routes from /lfx entry point. README updated with usage guide. Signed-off-by: Nirav Patel <npatel@linuxfoundation.org>
4308936 to
a92b0fb
Compare
- Remove hardcoded "8 skills" count from README - Use mktemp for branch discovery temp files (avoid clobbering) - Use origin/main instead of main in --no-merged (works without local ref) - Replace hardcoded username in manifest path example with $HOME - Reject / and .. in journey names (used in paths and branch names) Signed-off-by: Nirav Patel <npatel@linuxfoundation.org>
andrest50
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/lfx-test-journeyskill that combines feature branches from multiple repos into git worktrees for end-to-end journey testingcd+ run commandscreate,status,refresh,edit,teardown,list/lfxentry point ("test a journey", "combine branches", etc.)Test plan
/lfxentry pointcreateflow end-to-end (repo discovery, branch selection, worktree creation, merge, manifest)ls -dglob withfind)