Skip to content

fix(ci): use comma-separated list for include_files, remove default files#111

Merged
emsearcy merged 1 commit intomainfrom
agaete/license-check-fix
Feb 18, 2026
Merged

fix(ci): use comma-separated list for include_files, remove default files#111
emsearcy merged 1 commit intomainfrom
agaete/license-check-fix

Conversation

@agaetep
Copy link
Contributor

@agaetep agaetep commented Feb 18, 2026

This pull request updates the license header check workflow configuration to correctly list the set of files included in the license check. Additionally, files that are already included as defaults were removed.

JIRA check (not related to ticket) LFXV2-00

…iles

Signed-off-by: Antonia Gaete <agaete@linuxfoundation.org>
Copilot AI review requested due to automatic review settings February 18, 2026 18:04
@agaetep agaetep requested review from a team and emsearcy as code owners February 18, 2026 18:04
@coderabbitai
Copy link

coderabbitai bot commented Feb 18, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

The license header check workflow configuration simplifies the include_files input by replacing multiple file type patterns (*.tpl, *.txt, *.yaml, .yml, .gitignore) with a single pattern (.tpl), narrowing the scope of files subject to the license header check.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/license-header-check.yml
Simplified include_files parameter from a multi-pattern array to a single file pattern (*.tpl), reducing the number of file types checked for license headers.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating the license header check workflow to use a comma-separated list for include_files and removing default files.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose of updating the license header check workflow configuration and file inclusion.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch agaete/license-check-fix

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request modifies the license header check workflow configuration to simplify the include_files parameter. The change converts from a multi-line YAML array format to a single-line string containing only *.tpl, removing the previously listed patterns for *.txt, *.yaml, *.yml, and .gitignore. The PR description states these removed patterns are already included as defaults in the reusable workflow.

Changes:

  • Simplified include_files from multi-line YAML array to single-line string format
  • Removed file patterns assumed to be defaults (*.txt, *.yaml, *.yml, .gitignore)
  • Retained only *.tpl pattern for explicit inclusion

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@emsearcy emsearcy merged commit da94c18 into main Feb 18, 2026
10 checks passed
@emsearcy emsearcy deleted the agaete/license-check-fix branch February 18, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants