Graphical changes#8
Closed
ArjenBalfoort wants to merge 10 commits into
Closed
Conversation
added 10 commits
July 27, 2012 17:17
modified: debian/postinst modified: usr/lib/live-installer/frontend/gtk_interface.py modified: usr/lib/live-installer/installer.py modified: usr/share/applications/debian-installer-launcher.desktop deleted: usr/share/icons/live-installer.xpm renamed: usr/share/live-installer/bullet-point.png -> usr/share/live-installer/bullet-point-gnome.png new file: usr/share/live-installer/bullet-point-kde.png typechange: usr/share/live-installer/bullet-point.png modified: usr/share/live-installer/interface.glade renamed: usr/share/icons/live-installer.png -> usr/share/live-installer/logo-gnome.png new file: usr/share/live-installer/logo-kde.png typechange: usr/share/live-installer/logo.png deleted: usr/share/live-installer/logo.svg modified: usr/share/menu/live-installer
KDE was not detected correctly.
There were rare cases of live-installer crashes Use threading to prevent live-installer to crash when something goes bad in the execution of the JavaScript code of the slideshow
I've built the slideshow code from scratch and eliminated any JavaScript I could find, leaving only html and css. In fact, my solution is old school: read a template and copy language specific text in that template. No transitions, just showing one page after the other.
Only English and Dutch for now.
ggiesen
added a commit
to ggiesen/live-installer
that referenced
this pull request
Jun 14, 2026
… wifi filter, doc nits) linuxmint#4 [Low] discovery now genuinely excludes wifi from by-mac candidates: the ARPHRD_ETHER (type 1) check does NOT exclude wifi (wifi is type 1 too), so also skip interfaces with a sysfs wireless/ subdir. Comment fixed to describe what the check actually does. linuxmint#5 [Med] discovery drops sentinel/placeholder DMI values (all-zero/all-FF/ QEMU-default product_uuid; 'Default string', 'To Be Filled By O.E.M.', etc. product_serial) so a by-uuid/ or by-serial/ config can't match every defective unit in a fleet; the skip is logged. linuxmint#6 [Low,docs] steer network examples to routes: [{to: default, via}] as the canonical default-gateway form; gateway4/6 documented as legacy. linuxmint#7 [Low,docs] document that ambiguous NM matches are undefined — bind by MAC or a unique interface name; no autoconnect-priority is emitted. linuxmint#8 [Low] document the TFTP client's RFC1350 size assumption (small files; use HTTP for large) and warn past 256 KiB. (Full RFC2347 negotiation remains queued.) linuxmint#9 [Low,docs] document on_no_match's future intended values. 6 new tests (260 unit total).
ggiesen
added a commit
to ggiesen/live-installer
that referenced
this pull request
Jun 14, 2026
…ck (item B) The built-in TFTP client now requests RFC 2347 options (RFC 2348 blksize 1428, RFC 2349 tsize) and handles the OACK: parse the negotiated blksize, ACK block 0, then receive at that size. Two fallbacks keep it working against any server: - option-unaware server replies with DATA block 1 -> use the 512-byte RFC 1350 default already in place (no special handling needed); - strict server replies ERROR code 8 (option negotiation) -> retry the request once with no options. The transfer's terminal-block test uses the negotiated blksize, not a hardcoded 512. Tests cover both modes: the existing roundtrip cases now exercise the no-OACK fallback (the default test server ignores options); new cases add blksize=1024 OACK negotiation, ERROR-8 -> bare-retry fallback, and OACK parsing. 263 unit tests pass. Closes review linuxmint#8 / backlog item B. Docs updated (TFTP transport row).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor graphical changes to make live-installer look more like ubiquity.