Conversation
Member
|
Hi, Can you explain the benefits of this change? |
Author
|
Also need to edit /usr/lib/live-installer/frontend/gtk_interface.py |
ggiesen
added a commit
to ggiesen/live-installer
that referenced
this pull request
Jun 14, 2026
… wifi filter, doc nits) linuxmint#4 [Low] discovery now genuinely excludes wifi from by-mac candidates: the ARPHRD_ETHER (type 1) check does NOT exclude wifi (wifi is type 1 too), so also skip interfaces with a sysfs wireless/ subdir. Comment fixed to describe what the check actually does. linuxmint#5 [Med] discovery drops sentinel/placeholder DMI values (all-zero/all-FF/ QEMU-default product_uuid; 'Default string', 'To Be Filled By O.E.M.', etc. product_serial) so a by-uuid/ or by-serial/ config can't match every defective unit in a fleet; the skip is logged. linuxmint#6 [Low,docs] steer network examples to routes: [{to: default, via}] as the canonical default-gateway form; gateway4/6 documented as legacy. linuxmint#7 [Low,docs] document that ambiguous NM matches are undefined — bind by MAC or a unique interface name; no autoconnect-priority is emitted. linuxmint#8 [Low] document the TFTP client's RFC1350 size assumption (small files; use HTTP for large) and warn past 256 KiB. (Full RFC2347 negotiation remains queued.) linuxmint#9 [Low,docs] document on_no_match's future intended values. 6 new tests (260 unit total).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need edit /usr/lib/live-installer/installer.py and /usr/lib/live-installer/frontend/gtk_interface.py to optimize installing national (non-english) keyboard layouts