port to mutter 3.4.0#13
Merged
Conversation
We will eventually land jhbuild work to grep for warnings; for now breaking the build is just too painful.
If we are moving in snap mode (shift pressed) we don't want to tile. We must also cancel any pending tiling if snap mode is activated during the move drag. https://bugzilla.gnome.org/show_bug.cgi?id=662270
Since invisible draggable borders have been around, there isn't really a big need for this feature https://bugzilla.gnome.org/show_bug.cgi?id=660129
This avoids a potentially costly allocation on every pixmap update. https://bugzilla.gnome.org/show_bug.cgi?id=662225
… Turn off -Werror by default" This reverts commit a26e72c452d98c5c2c68dcaa3d8117b86af1f9ce. https://bugzilla.gnome.org/show_bug.cgi?id=662574
meta_window_move_resize_frame operates much like meta_window_move_resize, but ensures the window and its frame (if present) will fit within the specified dimensions. https://bugzilla.gnome.org/show_bug.cgi?id=651899
This hint reflects whether a window appears focused. https://bugzilla.gnome.org/show_bug.cgi?id=661427
gboolean is a typedef for int, so it doesn't matter too much https://bugzilla.gnome.org/show_bug.cgi?id=660941
Move preferences to GSettings, using mainly shared schemas from gsettings-desktop-schemas. Unlike GConf, GSettings support is not optional, as Gio is already a hard dependency of GTK+. https://bugzilla.gnome.org/show_bug.cgi?id=635378
The version has been bumped, so we can now depend on a version which includes the new wm schemas.
Commit d0910da036c merged the visual-bell/visual-bell-type options, but the change turned out too disruptive for gnome-control-center / gnome-shell, so gsettings-desktop-schemas commit a5819b2a4e9 re-added the separate option.
Rather than defining keybindings in static arrays generated at compile time, store them in a hash table initialized in meta_display_init_keys() and filled in init_builtin_keybindings(). This is a prerequisite for allowing to add/remove keybindings at runtime. https://bugzilla.gnome.org/show_bug.cgi?id=663428
Add meta_display_add_keybinding()/meta_display_remove_keybinding(), which allow to add/remove keybindings dynamically at runtime. https://bugzilla.gnome.org/show_bug.cgi?id=663428
The workspaces-only-on-primary preference changes how windows are displayed, so listen for pref changes and update the visibility accordingly. https://bugzilla.gnome.org/show_bug.cgi?id=664853
Usually tiling involves a size change and the frame is redrawn automatically, however this is not the case when switching directly between left- and right-tiled. Ensure that a redraw happens in that case as well. https://bugzilla.gnome.org/show_bug.cgi?id=648700
In order to be able to toggle between tiled and normal/maximized states, we need to keep track of the last full maximization state. https://bugzilla.gnome.org/show_bug.cgi?id=648700
The current code requires windows to be resizable to be considered for tiling, which excludes all maximized/tiled windows. While this restriction concurs with the desired behavior for edge-tiling, it feels overly restrictive for keybindings. As the edge-tiling code in update_move() already ensures the above restriction, it seems save to remove it from the can_tile_maximized() function, assuming that windows that are not meant to be tiled or maximized won't provide a maximize function. https://bugzilla.gnome.org/show_bug.cgi?id=648700
In order to support keybindings for window tiling, we need to determine whether a window is tilable or not, so make this public. https://bugzilla.gnome.org/show_bug.cgi?id=648700
Having keybindings for side-by-side tiling has been requested for a long time, so add this support now. https://bugzilla.gnome.org/show_bug.cgi?id=648700
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
This is a new value, not associated with any keybindings, useful when the WM needs to order the applications by last-interaction, taking into account all windows. https://bugzilla.gnome.org/show_bug.cgi?id=667552
"warning: 'match_tile_mode' may be used uninitialized in this function", it complains. It thinks it's not unused because of other values of window->tile_mode, but other complex logic ensures that it can't be META_TILE_MAXIMIZED, so this is a safe commit.
This reverts commit 335d211204dbb557d7c89ce782ffb548e574f675 trying not to trigger the uninitialized variable warning in gcc.
This prevents an invalid read and also improves performance slightly. https://bugzilla.gnome.org/show_bug.cgi?id=672374
…using Commit 2fc880db switched from focusing the topmost window as the default window to focusing the MRU window. This was done in alignment with the introduction of per-workspace MRU lists to avoid problems where the window stack was inadvertently changed when focusing windows during window switches. Now that focusing windows don't have as big an impact on the stacking order, we can revert back to focusing the top window, which is less confusing to the user. For now, leave per-workspace MRU lists, as they're a pretty good approximation of a global MRU list, and it works well enough. https://bugzilla.gnome.org/show_bug.cgi?id=620744
When muffin recognizes a full-screen window, it tries to raise it to the top of the stack. Unfortunately, a recent rewrite of the stack code didn't do well with raising a window to the top of the stack if the stack wasn't in a consistent state -- it would crash. Ensure that the stack is in a consistent state at the top of meta_stack_raise/meta_stack_lower. https://bugzilla.redhat.com/show_bug.cgi?id=806437 https://bugzilla.gnome.org/show_bug.cgi?id=672797
We need a clean uninstall for 'make distcheck' to pass; libtool hijinks leave a left-over plugins/default.so - remove it manually.
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It requires some changes in cinnamon, I'll send pull request for this.
Settings match default mutter, so probably you want review them.
Since muffin is now ported to gsettings, probably cinnamon-settings more broken. I can't test this.