Consistently include a space *before* parameters when building exec_string#270
Merged
mtwebster merged 1 commit intolinuxmint:masterfrom Nov 27, 2023
Merged
Conversation
…tring This fixes `custom_parameters` having two spaces before it and none after it for Firefox apps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #269, by fixing
custom_parametershaving two spaces before it and none after it for Firefox apps.By include the separating space at the beginning of each new parameter string, instead of switching between the beginning and end, there is less chance of this error happening again.