Change border of pages to a realistic shadow, make thumbnails styleable via CSS #248
Merged
clefebvre merged 7 commits intolinuxmint:masterfrom Nov 16, 2018
Merged
Change border of pages to a realistic shadow, make thumbnails styleable via CSS #248clefebvre merged 7 commits intolinuxmint:masterfrom
clefebvre merged 7 commits intolinuxmint:masterfrom
Conversation
Piiit
changed the title
Piiit
changed the title
Collaborator
Author
|
@clefebvre Done. Please test and merge :-) |
Piiit
changed the title
Collaborator
Author
|
@JosephMcc found some compatibility issues regarding GTK 3.22 CSS handling, which need to be fixed first. Back to WIP... |
based on commit f1d24b0a6b799abc4ff948286c121b6a5bb7a909
…with CSS
commit 30d1c3f4d71d5f53603076c7c93a5999e65eec5a
Author: William Jon McCann <jmccann@redhat.com>
Date: Sun Dec 23 13:18:49 2012 +0100
libdocument: Allow sidebar thumbnails to be styled with CSS
https://bugzilla.gnome.org/show_bug.cgi?id=653294
...this commit includes also:
commit 16bbee9df797c9498b0be983d1bcde309e281824
Author: Trinh Anh Ngoc <atw1990@gmail.com>
Date: Sun Nov 29 09:28:29 2015 +0700
shell: Update sidebar thumbnails CSS nodes
Fixes frameless thumbnails with GTK+ 3.20
https://bugzilla.gnome.org/show_bug.cgi?id=758793
commit 7a6b53a1b4083cf6a3d9660dfc7978bb37c3d9e7
Author: William Jon McCann <jmccann@redhat.com>
Date: Sun Dec 23 10:49:58 2012 +0100
view: Use a rendered frame instead of custom border
So it can be styled with CSS.
https://bugzilla.gnome.org/show_bug.cgi?id=653294
commit 38528f9f1e225f4d661a1d813c5fae45fd6707d4
Author: Carlos Garcia Campos <carlosgc@gnome.org>
Date: Sun Dec 23 11:28:46 2012 +0100
view: Fix page background rendering while loading
commit 48110cb41681d8babe94cc8ee3fb26a533d16671
Author: Carlos Garcia Campos <cgarcia@igalia.com>
Date: Mon Aug 4 12:50:41 2014 +0200
previewer: Add CSS file for EvView styling
EvView CSS used to be shared in adwaita theme, but now that adwaita has
been merged into GTK+ and app specific CSS has been removed, we need to
add the EvView CSS to all of its users.
Always draw thumbnail frames styled by CSS (see .page-thumbnail inside shell/xreader.css), and not through hard-coded pixbuf manipulations.
The old calculation caused sometimes rounding errors, which could cut off the lower border line.
Piiit
changed the title
Collaborator
Author
|
This is a better solution now. I fixed also the css issues. Please re-test... |
Contributor
|
@Piiit I tested this again. It looks ok except the thumbnails in the recents view no longer get a border drawn around them. That needs to be fixed. |
Member
|
@Piiit @JosephMcc I'll merge this, I think it's a great improvement over master already. Recent thumbs could do with a border, but even now they look better than in master. PS: The CSS refers to a PNG for the thumb frame, is that OK in HiDPI? Would it look cleaner if it was just 100% CSS, without the need for any image at all? (i.e. a clean border, as opposed to something that's trying to look like a page). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.