Skip to content

feat(sprites): support non svg sprites#2736

Merged
blacha merged 2 commits intomasterfrom
feat/support-png-sprites
Mar 20, 2023
Merged

feat(sprites): support non svg sprites#2736
blacha merged 2 commits intomasterfrom
feat/support-png-sprites

Conversation

@blacha
Copy link
Copy Markdown
Member

@blacha blacha commented Mar 15, 2023

adds support for --extension .png to load png (or any other format that libvips supports) as sprites

blacha added 2 commits March 16, 2023 12:46
adds support for `--extension .png` to load png (or any other format that libvips supports) as sprites
@blacha blacha requested a review from a team as a code owner March 15, 2023 23:47
@ajacombs ajacombs added this pull request to the merge queue Mar 16, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 16, 2023
@blacha blacha added this pull request to the merge queue Mar 20, 2023
@blacha blacha merged commit 37fcc19 into master Mar 20, 2023
@blacha blacha deleted the feat/support-png-sprites branch March 20, 2023 04:33
@jleedev
Copy link
Copy Markdown

jleedev commented Aug 8, 2023

This is a breaking API change but was published with a minor version number.

@blacha
Copy link
Copy Markdown
Member Author

blacha commented Aug 8, 2023

@jleedev you are correct, this was not taged as a breaking change (missing a ! in the commit title.

We have a couple options, depending on the impact for you:

  1. We do nothing,
  2. We roll back this change, release a new patch version, then create a major version bump for the api change?

@jleedev
Copy link
Copy Markdown

jleedev commented Aug 8, 2023

Based on github code search, openstreetmap-americana might be the only code out there that is actually importing this api. so doing nothing is probably fine.

jleedev added a commit to osm-americana/openstreetmap-americana that referenced this pull request Aug 8, 2023
Update sprites parameter (linz/basemaps#2736)
jleedev added a commit to osm-americana/openstreetmap-americana that referenced this pull request Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants