refactor: templates for standardise-validate and create-collection topo-imagery commands TDE-1346 - #970
Merged
Conversation
amfage
requested review from
MDavidson17,
blacha,
paulfouquet and
schmidtnz
and removed request for
MDavidson17
February 7, 2025 02:13
paulfouquet
reviewed
Feb 9, 2025
paulfouquet
left a comment
paulfouquet
left a comment
Contributor
There was a problem hiding this comment.
The national-dem WorkflowTemplate is also using this two templates. It would be great to point it to these new templates.
amfage
marked this pull request as draft
February 9, 2025 20:36
amfage
marked this pull request as ready for review
February 13, 2025 03:22
paulfouquet
suggested changes
Feb 13, 2025
schmidtnz
reviewed
Feb 13, 2025
amfage
marked this pull request as draft
February 13, 2025 20:41
amfage
marked this pull request as ready for review
February 14, 2025 02:41
paulfouquet
previously approved these changes
Feb 16, 2025
schmidtnz
reviewed
Feb 18, 2025
schmidtnz
reviewed
Feb 18, 2025
schmidtnz
reviewed
Feb 18, 2025
schmidtnz
reviewed
Feb 23, 2025
paulfouquet
approved these changes
Feb 24, 2025
ctali
pushed a commit
that referenced
this pull request
Jun 29, 2026
… (#970) #### Motivation We are populating title inside collection.json file from the etl. The `collection.title` is the combined title when processing multiple vector layers which is using the parameter from `etl --title`. And all the `collection.links` should contain the `lds:title` from the lds export. We should using this title when there is only one lds layer exists in the etl output. #### Modification Get the title from collection.json and get the title from `lds:title` for individual vector output. #### Checklist - [ ] Tests updated - no test - [ ] Docs updated - no doc - [x] Issue linked in Title
ctali
pushed a commit
that referenced
this pull request
Jun 29, 2026
🤖 I have created a release *beep* *boop* --- ## [3.7.0](linz/argo-tasks@v3.6.1...v3.7.0) (2024-05-08) ### Features * **basemaps:** Get vector title from the collection.json file. BM-1017 ([#970](linz/argo-tasks#970)) ([73f912f](linz/argo-tasks@73f912f)) * stac validate links checksum TDE-1134 ([#972](linz/argo-tasks#972)) ([3bd091c](linz/argo-tasks@3bd091c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The standardise-validate and create-collection commands need to be used by multiple workflows, as we are now publishing multiple products such as a National DEM and National Hillshades.
Modification
Create separate WorkflowTemplates for
standardise-validateandcreate-collection.Update current WorkflowTemplates
national-demandimagery-standardisingthat use these templates.Checklist