refactor: convert error codes, breakpoint types and setting keys to enums - #14
Merged
Merged
Conversation
…nums Replace three groups of class constants with native PHP enums: - ErrorCode becomes an int-backed enum of the DBGp error codes; ResponseBuilder::error() and CommandDispatcher::error() now accept it directly and render ->value on the wire. - The Breakpoint TYPE_* string constants move to a new string-backed BreakpointType enum; Breakpoint::$type is now typed as the enum and breakpoint_set validates the -t argument with tryFrom(). - The Settings key constants move to a new string-backed Setting enum; the Settings bag accepts Setting keys while keeping its string-keyed storage, so the documented config array keys stay unchanged, and Debugger derives the allowed keys from Setting::cases(). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DJrpKBnxGuETRv7UFzUpcF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts three groups of class constants to native PHP enums, as requested.
Changes
ErrorCode(int-backed enum)The DBGp error-code constants (
PARSE_ERROR,UNIMPLEMENTED,BREAKPOINT_INVALID, …) become cases of an int-backed enum (ErrorCode::ParseError,ErrorCode::Unimplemented, …), keeping the range grouping comments from the spec.ResponseBuilder::error()andCommandDispatcher::error()now takeErrorCodeinstead of a bareintand render->valueon the wire, so an arbitrary integer can no longer be sent as an error code.BreakpointType(new string-backed enum)The
Breakpoint::TYPE_LINE/TYPE_CONDITION/TYPE_EXCEPTIONstring constants move to a dedicatedBreakpointTypeenum (Line,Conditional,Exception).Breakpoint::$typeis now typed as the enum, andbreakpoint_setvalidates the-targument withBreakpointType::tryFrom()instead of a hand-written three-way comparison. The DBGp XML output still carries the same string values via->value. TheHIT_*hit-condition constants are untouched, as they were not in scope.Setting(new string-backed enum)The
Settingskey constants (CLIENT_HOST,CLIENT_PORT,IDE_KEY, …) move to aSettingenum whose backing values are the documented public config-array keys, so the publicDebugger::attach(['client_port' => …])API is unchanged. TheSettingsbag's methods (has/get/set/string/int/stringOrNull/stringList) now acceptSettingwhile keeping string-keyed storage internally, andDebugger::mapArrayKeys()derives its allowlist fromSetting::cases()instead of a hand-maintained list.Verification
composer test— 137 tests, 656 assertions, all passingcomposer phpstan— level max, no errorscomposer cs:check— clean🤖 Generated with Claude Code
https://claude.ai/code/session_01DJrpKBnxGuETRv7UFzUpcF
Generated by Claude Code