Skip to content

Update simple-icons#1985

Merged
lissy93 merged 3 commits into
lissy93:masterfrom
jonas-schulze:update-simple-icons
Mar 15, 2026
Merged

Update simple-icons#1985
lissy93 merged 3 commits into
lissy93:masterfrom
jonas-schulze:update-simple-icons

Conversation

@jonas-schulze
Copy link
Copy Markdown
Contributor

@jonas-schulze jonas-schulze commented Jan 28, 2026

jonas-schulze Quick jonas-schulze /update-simple-icons → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 0 Label Unchecked Tasks Powered by Pull Request Badge

Category: Update dependency

Overview
Update simple-icons because I would like to use the HedgeDoc icon (introduced in v15 but I thought one might as well use the most recent version).

Code Quality Checklist (Please complete)

I am not familiar with Javascript; I merely edited package.json, built the container, and checked that si-hedgedoc was working. If there is anything else I should do, please let me know, though, I would prefer if you could take over this branch. 🙂

  • All changes are backwards compatible
    • Major releases of simple-icons remove some icons, which will affect some users of dashy
    • v15 removed, e.g., AWS
    • v16 removed, e.g., Slack
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • (If significant change) Bumps version in package.json

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 28, 2026

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit d40e42b
🔍 Latest deploy log https://app.netlify.com/projects/dashy-dev/deploys/69b6cfdeea3fc60009a31f8d
😎 Deploy Preview https://deploy-preview-1985--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Owner

@lissy93 lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonas-schulze!
I've made a small update here, as the lockfile also needed updating (happens by running yarn install). And now all checks pass, ready to merge :)

@lissy93 lissy93 merged commit 51b89d2 into lissy93:master Mar 15, 2026
9 checks passed
@jonas-schulze jonas-schulze deleted the update-simple-icons branch March 15, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants