Schedules requestUpdate in initialize rather than connectedCallback
#606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 11, 2019 18:12
…ack` Fixes #594. Ensures an early access of `updateComplete` will not complete before the element has first updated (at connection time).
kevinpschaaf
approved these changes
Mar 14, 2019
| this._hasConnectedResolver(); | ||
| this._hasConnectedResolver = undefined; | ||
| } else { | ||
| this.requestUpdate(); |
Member
There was a problem hiding this comment.
Summary here is we're considering the fact that requestUpdate was called every connection a bug, since the intention of this code was only to ensure a "request if not yet requested" one time on boot-up.
If users depend on tree-state in render(), they should manually requestUpdate in connectedCallback to ensure render is called when the tree state changes.
justinfagnani
approved these changes
Mar 14, 2019
Contributor
justinfagnani
left a comment
justinfagnani
left a comment
There was a problem hiding this comment.
Can you file a documentation bug too? The update lifecycle docs lack some detail around this, even before the change.
Member
Author
|
Filed #614. |
|
Small issue. The comment that was left in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #594. Ensures an early access of
updateCompletewill not complete before the element has first updated (at connection time).