Conversation
Member
Author
|
@paganol , apart from some speed/memory optimizations, this should fix #134. Does it look reasonable? Unfortunately, to match the API used by other modules, I had to introduce a few breaking changes: |
Member
|
Hi @ziotom78. It looks great to me. I made few corrections in the documentation. The only substantial change I made is that I put to zero the frequency zero in the 1/f model. litebird_sim/litebird_sim/noise.py Line 47 in 861d4c3 If this is ok for you, we can merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces some breaking changes to the noise module. Specifically:
add_noisehas been renamed toadd_noise_to_observations(similar toadd_dipole_to_observations), and a new functionadd_noisenow works on plain NumPy arraysadd_white_noiseandadd_one_over_f_noiseare now correctly exported