feat: return SamlMessage from binding receive() method#105
Merged
Conversation
Previously receive() returned void, requiring callers to retrieve the message separately via $messageContext->getMessage(). The official documentation example incorrectly showed assigning the return value, leading to a null reference error. Return the deserialized SamlMessage directly from receive() so that both usage patterns work: $message = $binding->receive($request, $messageContext); // or $binding->receive($request, $messageContext); $message = $messageContext->getMessage(); Closes #89
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AbstractBinding::receive()now returnsSamlMessageinstead ofvoidHttpPostBindingandHttpRedirectBindingreturn the deserialized messageContext
The official documentation example showed:
Since
receive()returnedvoid,$responsewas alwaysnull. Users had to know to call$messageContext->getMessage()instead — which is not documented.With this change, both patterns work:
This is non-breaking: existing code that ignores the return value continues to work.
Closes #89