feat(api)!: updates book transfer status, updates to transactions, add currency model#305
Merged
Merged
Conversation
…d currency model - Breaking: Removed book transfer status `PENDING`. While technically a breaking change, that was a mistake and should not impact user code, the API never accepted `PENDING` as a status for book transfer. - Add book transfer status `REVERSED` - Add `updated` and `amounts` fields to transactions - Add shared model `Currency` # Migration The SDK previously stated that `PENDING` was an accepted value for book transfer status. That was a mistake, `PENDING` has never been accepted by the API for book transfers. While this is a breaking change we do not expect user code to be impacted.
stainless-app Bot
added a commit
that referenced
this pull request
Sep 17, 2024
…d currency model (#305) - Breaking: Removed book transfer status `PENDING`. While technically a breaking change, that was a mistake and should not impact user code, the API never accepted `PENDING` as a status for book transfer. - Add book transfer status `REVERSED` - Add `updated` and `amounts` fields to transactions - Add shared model `Currency` # Migration The SDK previously stated that `PENDING` was an accepted value for book transfer status. That was a mistake, `PENDING` has never been accepted by the API for book transfers. While this is a breaking change we do not expect user code to be impacted.
Merged
stainless-app Bot
added a commit
that referenced
this pull request
Sep 17, 2024
…d currency model (#305) - Breaking: Removed book transfer status `PENDING`. While technically a breaking change, that was a mistake and should not impact user code, the API never accepted `PENDING` as a status for book transfer. - Add book transfer status `REVERSED` - Add `updated` and `amounts` fields to transactions - Add shared model `Currency` # Migration The SDK previously stated that `PENDING` was an accepted value for book transfer status. That was a mistake, `PENDING` has never been accepted by the API for book transfers. While this is a breaking change we do not expect user code to be impacted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PENDING. While technically a breaking change, that was a mistake and should not impact user code, the API never acceptedPENDINGas a status for book transfer.REVERSEDupdatedandamountsfields to transactionsCurrencyMigration
The SDK previously stated that
PENDINGwas an accepted value for book transfer status. That was a mistake,PENDINGhas never been accepted by the API for book transfers.While this is a breaking change we do not expect user code to be impacted.