Skip to content

fix(client): don't call validate() during deserialization if we don't have to #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stainless-app merged 1 commit into from
Mar 28, 2025
Merged

fix(client): don't call validate() during deserialization if we don't have to #569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lithic-java-core/src/main/kotlin/com/lithic/api/core/BaseDeserializer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import com.fasterxml.jackson.databind.JsonMappingException
import com.fasterxml.jackson.databind.JsonNode
import com.fasterxml.jackson.databind.deser.ContextualDeserializer
import com.fasterxml.jackson.databind.deser.std.StdDeserializer
import com.lithic.api.errors.LithicInvalidDataException
import kotlin.reflect.KClass

abstract class BaseDeserializer<T : Any>(type: KClass<T>) :
Expand All @@ -29,6 +30,13 @@ abstract class BaseDeserializer<T : Any>(type: KClass<T>) :

protected abstract fun ObjectCodec.deserialize(node: JsonNode): T

protected fun <T> ObjectCodec.deserialize(node: JsonNode, type: TypeReference<T>): T =
try {
readValue(treeAsTokens(node), type)
} catch (e: Exception) {
throw LithicInvalidDataException("Error deserializing", e)
}

protected fun <T> ObjectCodec.tryDeserialize(
node: JsonNode,
type: TypeReference<T>,
Expand Down
20 changes: 8 additions & 12 deletions lithic-java-core/src/main/kotlin/com/lithic/api/models/ExternalBankAccountCreateParams.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,18 +416,14 @@ private constructor(
json.asObject().getOrNull()?.get("verification_method")?.asString()?.getOrNull()

if (verificationMethod == "EXTERNALLY_VERIFIED") {
tryDeserialize(
node,
jacksonTypeRef<ExternallyVerifiedCreateBankAccountApiRequest>(),
) {
it.validate()
}
?.let {
return Body(
externallyVerifiedCreateBankAccountApiRequest = it,
_json = json,
)
}
return Body(
externallyVerifiedCreateBankAccountApiRequest =
deserialize(
node,
jacksonTypeRef<ExternallyVerifiedCreateBankAccountApiRequest>(),
),
_json = json,
)
}

tryDeserialize(node, jacksonTypeRef<BankVerifiedCreateBankAccountApiRequest>()) {
Expand Down