[hoverstare] Docs: explain the review pipeline voting in docs/#5
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new documentation file, docs/pipeline.md, which details the architecture and rules of the review pipeline. The reviewer suggested several clarifications to ensure the documentation accurately reflects the underlying implementation, specifically regarding the clamping range of passes, the minimum constraint of the verifier budget, and the behavior of pass_findings when lanes fail.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| | Field | Meaning | | ||
| |---|---| | ||
| | `passes_run` | Number of lanes that completed successfully. | | ||
| | `pass_findings` | Findings count per lane, in lane order. | |
There was a problem hiding this comment.
Clarify that pass_findings only includes findings from successful lanes. If a lane fails, its findings are omitted from this list rather than being recorded as 0.
| | `pass_findings` | Findings count per lane, in lane order. | | |
| | pass_findings | Findings count per successful lane, in relative lane order (failed lanes are omitted). | |
| Verifier constraints: | ||
|
|
||
| - temperature forced to `0.0`; | ||
| - budget = `max_tool_calls / 2`; |
There was a problem hiding this comment.
The verifier budget is clamped to a minimum of 1 in the implementation ((cfg.max_tool_calls / VERIFIER_TOOL_BUDGET_DIVISOR).max(1)). It would be more precise to document this minimum constraint.
| - budget = `max_tool_calls / 2`; | |
| - budget = max(1, max_tool_calls / 2); |
|
|
||
| - **Small diff**: if the diff has fewer than 50 added lines, the pipeline is forced to `passes = 1` + `verify = true`. Small changes are not worth the multi-pass cost. | ||
| - **Straight-through**: if `passes = 1` and `verify = false`, the pipeline short-circuits to `analyze_with_backend()` and behaves exactly like the single-pass backend with no voting or verifier. | ||
| - Otherwise, the configured `passes` value is clamped to the number of available lenses (currently 3). |
There was a problem hiding this comment.
The configured passes value is clamped to the range [1, 3] (i.e., (cfg.passes as usize).clamp(1, LENSES.len())). Clarifying that it is clamped to a range of 1 to 3 is more precise than just saying it is clamped to the number of available lenses.
| - Otherwise, the configured `passes` value is clamped to the number of available lenses (currently 3). | |
| - Otherwise, the configured passes value is clamped to the range of available lenses (currently 1 to 3). |
|
@hoverstare 在文档开头加一段不超过三行的 TL;DR，并确保文档链接到 specs/05-review-pipeline.md |
|
@hoverstare 在文档开头加一段不超过三行的 TL;DR，并在文档中链接 specs/05-review-pipeline.md |
|
本轮改动已提交并推送： Done. Added a two-line TL;DR paragraph to |
liuchong
left a comment
liuchong
left a comment
There was a problem hiding this comment.
👁 HoverStare Review
Review scope — Full review; 1 file(s)
This PR is documentation-only, adding docs/pipeline.md to describe the review pipeline architecture, lanes, clustering, voting, and verifier behavior. No concrete defects, security vulnerabilities, or logic errors were identified in the added documentation.
✅ No defects found.
liuchong
left a comment
liuchong
left a comment
There was a problem hiding this comment.
👁 HoverStare Review
Review scope — Full review; 1 file(s)
The PR adds only documentation describing the review pipeline; no executable code or security-sensitive configuration is changed, so no security or boundary defects are present.
✅ No defects found.
|
@hoverstare merge |
|
✅ 已合并（squash）： |
…; release v0.1.0 - README (en/zh-CN/ru/fr/de/es): Develop mode — issues & PRs as your AI IDE - AGENTS.md: develop/devagent/git modules, M11-M13 history, key facts - spec 11: Implemented (full Actions lifecycle verified on issue #4 / PR #5) - bump hoverstare + bugbot alias to 0.1.0, action.yml default v0.1.0
1 participant
Created
docs/pipeline.mdwith an operator-facing explanation of the review pipeline:passes=1no-verify straight-through).PipelineStatsglossary.src/pipeline.rs,specs/05-review-pipeline.md, andspecs/04-agent-backend.md.No code changes were made.
Closes #4
由 HoverStare 实现。后续调整请在 PR 评论区
@hoverstare下达。