Skip to content

Conversation

@toubatbrian
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2026

⚠️ No Changeset found

Latest commit: a5c29ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@toubatbrian toubatbrian changed the base branch from main to feat/barge-in February 10, 2026 01:39
@toubatbrian toubatbrian requested a review from a team February 10, 2026 01:42
@chatgpt-codex-connector
Copy link

💡 Codex Review

minEndpointingDelay: this.agentSession.options.turnHandling.endpointing.minDelay,
maxEndpointingDelay: this.agentSession.options.turnHandling.endpointing.maxDelay,

P1 Badge Convert endpointing delays to milliseconds before passing

turnHandling.endpointing is documented in seconds (defaultEndpointingConfig is 0.5/3.0), but these values are forwarded directly to AudioRecognition, whose end-of-turn scheduler does Date.now() arithmetic and delay(...) in milliseconds. With defaults, this makes endpointing effectively ~0.5ms instead of 500ms, so user turns are cut off almost immediately in normal VAD/STT flows. Multiply by 1000 (or normalize centrally) before assigning minEndpointingDelay/maxEndpointingDelay.


const detector = new AdaptiveInterruptionDetector();

P1 Badge Gate adaptive detector creation on explicit mode

This unconditionally constructs AdaptiveInterruptionDetector whenever the config is compatible unless mode is explicitly false/'vad', which means the default mode: undefined now triggers adaptive initialization. AdaptiveInterruptionDetector can throw when LiveKit inference credentials are absent, so sessions that previously ran with standard STT+VAD interruption can now fail during AgentActivity construction. Only instantiate adaptive mode when explicitly requested (or catch/fallback to VAD interruption).

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 6 additional findings.

Open in Devin Review

@toubatbrian toubatbrian merged commit 717e908 into feat/barge-in Feb 10, 2026
1 check passed
@toubatbrian toubatbrian deleted the brian/trace-metadata branch February 10, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant