chore(openai): remove STT.withGroq constructor#1321
Conversation
Port of livekit/agents#5555. Groq has its own dedicated plugin, so the OpenAI plugin no longer ships a Groq STT shortcut. - Remove `STT.withGroq` static constructor from `plugins/openai/src/stt.ts` - Drop the now-unused `GroqAudioModels` type from `plugins/openai/src/models.ts` - Drop the `GroqAudioModels` import from `stt.ts`
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
lukasIO
left a comment
lukasIO
left a comment
There was a problem hiding this comment.
lgtm, but similar question to @theomonnom on the python side about how we want to deal with the fact that this is a breaking change.
Should we deprecate it instead for now?
|
It was deleted on Python as well, so it lg to me |
3 participants
Summary
Port of livekit/agents#5555 — chore(openai): remove STT.with_groq constructor.
Groq has its own dedicated plugin (
livekit-plugins-groqon Python; the equivalent@livekit/agents-plugin-groqshould be the JS migration target for users). The OpenAI plugin's Groq STT shortcut is therefore being removed.Ported changes
STT.withGroqstatic constructor fromplugins/openai/src/stt.ts. This mirrors the removal ofSTT.with_groqin the Python OpenAI plugin (livekit/plugins/openai/stt.py).GroqAudioModelstype fromplugins/openai/src/models.ts. This mirrors removal of theGroqAudioModelsliteral inlivekit/plugins/openai/models.py.GroqAudioModelsimport fromstt.ts(the only consumer).Implementation nuances / divergence from the Python PR
The Python PR also removed the
GroqChatModelsliteral frommodels.py, which was safe in Python becauseLLM.with_groqhad already been deleted in a prior change. Inagents-js,LLM.withGroqstill exists inplugins/openai/src/llm.tsand referencesGroqChatModels. Therefore, this port intentionally keepsGroqChatModelsandLLM.withGroqin place — removing them would be an out-of-scope breaking change for JS users and is not part of upstream PR #5555.A follow-up port (mirroring whichever earlier Python PR removed
LLM.with_groq) will be needed to fully reach parity — when that lands,GroqChatModelsandLLM.withGroqcan be removed together.The Python PR also touches
uv.lock, which is Python-specific and intentionally not ported.Breaking change
Calls to
STT.withGroq({ ... })in user code will need to be migrated to the dedicated Groq plugin.Test plan
pnpm -w buildsucceeds (no remaining references toGroqAudioModelsorSTT.withGroq).pnpm -w testpasses.STT.withGroqorGroqAudioModels.Reviewers
cc @toubatbrian @livekit/agent-devs
🤖 Generated by Claude Code automation. Source PR: livekit/agents#5555.
Generated by Claude Code