Skip to content

fix: remove double URL-encoding in Deepgram STT plugin#1391

Merged
toubatbrian merged 2 commits intolivekit:mainfrom
haroldfabla2-hue:fix-double-url-encoding-deepgram
May 8, 2026
Merged

fix: remove double URL-encoding in Deepgram STT plugin#1391
toubatbrian merged 2 commits intolivekit:mainfrom
haroldfabla2-hue:fix-double-url-encoding-deepgram

Conversation

@haroldfabla2-hue
Copy link
Copy Markdown
Contributor

Fixes #1379

  • Remove encodeURIComponent() wrapper around URLSearchParams.append() calls
  • URLSearchParams.append() already handles URL encoding
  • Fixes issue where parameters with special chars (spaces, quotes, etc.) were corrupted
  • Example: keyterm=["Joe's Plumbing"] was being double-encoded to keyterm=Joe%2527s%2520Plumbing

- Remove encodeURIComponent() wrapper around URLSearchParams.append() calls
- URLSearchParams.append() already handles URL encoding
- Fixes issue where parameters with special chars (spaces, quotes, etc.) were corrupted
- Resolves livekit#1379 in livekit/agents-js
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 4, 2026

🦋 Changeset detected

Latest commit: 8552bd0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@livekit/agents-plugin-deepgram Patch
@livekit/agents Patch
@livekit/agents-plugin-anam Patch
@livekit/agents-plugin-baseten Patch
@livekit/agents-plugin-bey Patch
@livekit/agents-plugin-cartesia Patch
@livekit/agents-plugin-elevenlabs Patch
@livekit/agents-plugin-google Patch
@livekit/agents-plugin-hedra Patch
@livekit/agents-plugin-inworld Patch
@livekit/agents-plugin-lemonslice Patch
@livekit/agents-plugin-livekit Patch
@livekit/agents-plugin-neuphonic Patch
@livekit/agents-plugin-openai Patch
@livekit/agents-plugin-phonic Patch
@livekit/agents-plugin-resemble Patch
@livekit/agents-plugin-rime Patch
@livekit/agents-plugin-sarvam Patch
@livekit/agents-plugin-silero Patch
@livekit/agents-plugin-trugen Patch
@livekit/agents-plugin-xai Patch
@livekit/agents-plugins-test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 4, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ toubatbrian
❌ haroldfabla2-hue
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@toubatbrian toubatbrian merged commit 4a82900 into livekit:main May 8, 2026
5 of 6 checks passed
@github-actions github-actions Bot mentioned this pull request May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@livekit/agents-plugin-deepgram double-URL-encodes streaming params

3 participants