Skip to content

fix(inference): use non-empty placeholder apiKey for internal OpenAI client#1411

Merged
toubatbrian merged 2 commits into
mainfrom
fix/inference-llm-empty-apikey
May 7, 2026
Merged

fix(inference): use non-empty placeholder apiKey for internal OpenAI client#1411
toubatbrian merged 2 commits into
mainfrom
fix/inference-llm-empty-apikey

Conversation

@u9g
Copy link
Copy Markdown
Contributor

@u9g u9g commented May 7, 2026

Summary

  • inference.LLM constructs an OpenAI client with apiKey: '' as a placeholder, then overwrites client.apiKey with a fresh access token before each request (see LLMStream.run).
  • openai@6.36.0 tightened its credential check to reject empty-string apiKey at construction, so the constructor now throws before the per-request token is ever assigned.
  • Use a non-empty 'placeholder' string instead — the value is replaced before any actual HTTP call, so behavior is unchanged on every supported openai version.

Verified by linking @livekit/agents from livekit-examples/agent-starter-node against openai@6.36.0 and removing the workaround pnpm.overrides.openai: <6.36.0; the test suite passes.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 7, 2026

🦋 Changeset detected

Latest commit: e2d49be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@livekit/agents Patch
@livekit/agents-plugin-anam Patch
@livekit/agents-plugin-assemblyai Patch
@livekit/agents-plugin-baseten Patch
@livekit/agents-plugin-bey Patch
@livekit/agents-plugin-cartesia Patch
@livekit/agents-plugin-cerebras Patch
@livekit/agents-plugin-deepgram Patch
@livekit/agents-plugin-elevenlabs Patch
@livekit/agents-plugin-google Patch
@livekit/agents-plugin-hedra Patch
@livekit/agents-plugin-inworld Patch
@livekit/agents-plugin-lemonslice Patch
@livekit/agents-plugin-liveavatar Patch
@livekit/agents-plugin-livekit Patch
@livekit/agents-plugin-minimax Patch
@livekit/agents-plugin-mistral Patch
@livekit/agents-plugin-mistralai Patch
@livekit/agents-plugin-neuphonic Patch
@livekit/agents-plugin-openai Patch
@livekit/agents-plugin-phonic Patch
@livekit/agents-plugin-resemble Patch
@livekit/agents-plugin-rime Patch
@livekit/agents-plugin-runway Patch
@livekit/agents-plugin-sarvam Patch
@livekit/agents-plugin-silero Patch
@livekit/agents-plugins-test Patch
@livekit/agents-plugin-trugen Patch
@livekit/agents-plugin-xai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@u9g u9g enabled auto-merge (squash) May 7, 2026 01:28
@toubatbrian toubatbrian disabled auto-merge May 7, 2026 04:30
@toubatbrian toubatbrian merged commit 2f4714b into main May 7, 2026
9 checks passed
@toubatbrian toubatbrian deleted the fix/inference-llm-empty-apikey branch May 7, 2026 06:48
@github-actions github-actions Bot mentioned this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants