Skip to content

Revert remote session grant requirement#1480

Closed
rosetta-livekit-bot[bot] wants to merge 1 commit into
scuffles-badgers-accurstfrom
port-revert-session-grant
Closed

Revert remote session grant requirement#1480
rosetta-livekit-bot[bot] wants to merge 1 commit into
scuffles-badgers-accurstfrom
port-revert-session-grant

Conversation

@rosetta-livekit-bot
Copy link
Copy Markdown
Contributor

@rosetta-livekit-bot rosetta-livekit-bot Bot commented May 12, 2026

Summary

  • Reverts commit 2de7aa09e which added CanManageAgentSession permission checks to the remote session transport
  • Restores the previous remote_identity-based filtering behavior in RoomSessionTransport
  • Removes the IncomingMessage wrapper and _send_response helper, reverting to direct AgentSessionMessage passing

Test plan

  • Verify remote session connections work without CanManageAgentSession grants
  • Run test_session_host.py tests

Made with Cursor

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 12, 2026

⚠️ No Changeset found

Latest commit: 895e1c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

⚠️ 1 issue in files not directly in the diff

⚠️ Changeset describes a reverted change, will produce an incorrect CHANGELOG entry (.changeset/blue-kids-cough.md:1-5)

The changeset blue-kids-cough.md states "Require session management grant for remote sessions," but the grant requirement that was added in intermediate commits (9b85a822, 4f4348c7, d8376ab4, 859f75db) was fully reverted in the final commit (895e1c71). The net code diff between the merge base and HEAD is zero — only this changeset file was added. When the changeset bot processes this PR, it will generate a patch release note claiming a grant requirement was added, when in fact no code change was made. The changeset should either be removed entirely or updated to reflect the actual (empty) change.

View 3 additional findings in Devin Review.

Open in Devin Review

@chenghao-mou
Copy link
Copy Markdown
Member

Closing this since we didn't merge the upstream change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants