Revert remote session grant requirement#1480
Conversation
|
There was a problem hiding this comment.
Devin Review found 1 potential issue.
⚠️ 1 issue in files not directly in the diff
⚠️ Changeset describes a reverted change, will produce an incorrect CHANGELOG entry (.changeset/blue-kids-cough.md:1-5)
The changeset blue-kids-cough.md states "Require session management grant for remote sessions," but the grant requirement that was added in intermediate commits (9b85a822, 4f4348c7, d8376ab4, 859f75db) was fully reverted in the final commit (895e1c71). The net code diff between the merge base and HEAD is zero — only this changeset file was added. When the changeset bot processes this PR, it will generate a patch release note claiming a grant requirement was added, when in fact no code change was made. The changeset should either be removed entirely or updated to reflect the actual (empty) change.
View 3 additional findings in Devin Review.
|
Closing this since we didn't merge the upstream change. |
Summary
CanManageAgentSessionpermission checks to the remote session transportremote_identity-based filtering behavior inRoomSessionTransportIncomingMessagewrapper and_send_responsehelper, reverting to directAgentSessionMessagepassingTest plan
CanManageAgentSessiongrantstest_session_host.pytestsMade with Cursor