Skip to content

fix(telemetry): preserve OTEL logging for stale loggers#1562

Merged
toubatbrian merged 1 commit into
livekit:mainfrom
Cay-Zhang:fix-otel-stale-loggers
May 21, 2026
Merged

fix(telemetry): preserve OTEL logging for stale loggers#1562
toubatbrian merged 1 commit into
livekit:mainfrom
Cay-Zhang:fix-otel-stale-loggers

Conversation

@Cay-Zhang
Copy link
Copy Markdown
Contributor

Summary

  • keep a stable Pino multistream logger from initialization so captured root/child loggers retain the OTEL destination
  • make enableOtelLogging() flip the OTEL export gate instead of replacing the global logger
  • add a minimal regression test proving a logger captured before OTEL setup and a fresh logger both export after enablement
  • add a patch changeset

Fixes #1561

Validation

  • pnpm test agents/src/log.test.ts
  • pnpm format:check
  • pnpm exec eslint -f unix "agents/src/log.ts" "agents/src/log.test.ts"
  • pnpm build:agents

Note: pnpm --filter @livekit/agents lint currently fails on pre-existing warnings across unrelated files after the changed-file Prettier errors were fixed. pnpm --filter @livekit/agents api:check currently fails on API Extractor not supporting existing export * as ___ syntax in agents/dist/index.d.ts.

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 20, 2026

🦋 Changeset detected

Latest commit: 69269cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
@livekit/agents Patch
@livekit/agents-plugin-anam Patch
@livekit/agents-plugin-assemblyai Patch
@livekit/agents-plugin-baseten Patch
@livekit/agents-plugin-bey Patch
@livekit/agents-plugin-cartesia Patch
@livekit/agents-plugin-cerebras Patch
@livekit/agents-plugin-deepgram Patch
@livekit/agents-plugin-elevenlabs Patch
@livekit/agents-plugin-fishaudio Patch
@livekit/agents-plugin-google Patch
@livekit/agents-plugin-hedra Patch
@livekit/agents-plugin-hume Patch
@livekit/agents-plugin-inworld Patch
@livekit/agents-plugin-lemonslice Patch
@livekit/agents-plugin-liveavatar Patch
@livekit/agents-plugin-livekit Patch
@livekit/agents-plugin-minimax Patch
@livekit/agents-plugin-mistral Patch
@livekit/agents-plugin-mistralai Patch
@livekit/agents-plugin-neuphonic Patch
@livekit/agents-plugin-openai Patch
@livekit/agents-plugin-perplexity Patch
@livekit/agents-plugin-phonic Patch
@livekit/agents-plugin-resemble Patch
@livekit/agents-plugin-rime Patch
@livekit/agents-plugin-runway Patch
@livekit/agents-plugin-sarvam Patch
@livekit/agents-plugin-silero Patch
@livekit/agents-plugin-tavus Patch
@livekit/agents-plugins-test Patch
@livekit/agents-plugin-trugen Patch
@livekit/agents-plugin-xai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 20, 2026

CLA assistant check
All committers have signed the CLA.

@Cay-Zhang Cay-Zhang marked this pull request as ready for review May 20, 2026 22:38
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

Copy link
Copy Markdown
Contributor

@toubatbrian toubatbrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@toubatbrian toubatbrian merged commit 33bda3e into livekit:main May 21, 2026
6 checks passed
@github-actions github-actions Bot mentioned this pull request May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agent observability drops logs from loggers captured before OTEL setup

3 participants