Explain why ca-certificates is required in the example Dockerfile#1622
Draft
aryeila wants to merge 1 commit into
Draft
Explain why ca-certificates is required in the example Dockerfile#1622aryeila wants to merge 1 commit into
aryeila wants to merge 1 commit into
Conversation
The previous comment ("enables TLS/SSL for securely fetching dependencies")
implied this is generic Docker hygiene. That framing is misleading:
@livekit/rtc-node ships a native Rust core that reads the system trust store
via rustls-tls-native-roots, not Node's bundled CA roots. node:22-slim
doesn't ship /etc/ssl/certs/ca-certificates.crt, so without ca-certificates
Room.connect() fails with the misleading "failed to retrieve region info"
error.
Rewrite the comment to name the cause so a developer trimming the image
knows the line is load-bearing. No functional change.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Rewrite the in-Dockerfile
ca-certificatescomment inexamples/src/Dockerfile-exampleto explain why the line is load-bearing. No functional change.@livekit/rtc-nodeships a native Rust core that reads the system trust store viarustls-tls-native-roots, not Node's bundled CA roots.node:22-slimdoesn't ship/etc/ssl/certs/ca-certificates.crt, so withoutca-certificatesinstalled,Room.connect()fails with the misleadingfailed to retrieve region infoerror. The previous comment ("enables TLS/SSL for securely fetching dependencies") implied this was generic Docker hygiene that could be trimmed.End-to-end Docker repro confirms the failure mode (slim Node without
ca-certificatesreproduces the exact error string from livekit/agents-js#932) and the fix.Context
Filed against DOCS-1454.
Related PRs
The same comment rewrite is applied across the docs partial and sibling repos so they stay aligned:
pkg/agentfs/examples/node.DockerfileDockerfile