Skip to content

fix(elevenlabs): stop recognize from mutating instance language#1789

Merged
chenghao-mou merged 1 commit into
1.5.0from
moldier-than-drizzled
Jun 15, 2026
Merged

fix(elevenlabs): stop recognize from mutating instance language#1789
chenghao-mou merged 1 commit into
1.5.0from
moldier-than-drizzled

Conversation

@rosetta-livekit-bot

@rosetta-livekit-bot rosetta-livekit-bot Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Notes

  • agents-js does not currently have a Clova plugin; the matching JS side effect is in ElevenLabs STT's #recognizeImpl.
  • No tests added, matching the original fix.

Testing

  • pnpm exec prettier --check "plugins/elevenlabs/src/stt.ts" ".changeset/odd-languages-speak.md"
  • pnpm --filter @livekit/agents build
  • pnpm --filter @livekit/agents-plugin-elevenlabs build

Ported from livekit/agents#6097

Original PR description

_recognize_impl accepted a per-call language override but wrote it back to self._language, permanently changing the instance's language for all subsequent calls that don't specify one.

Fix: compute a local lang variable from the per-call override (falling back to self._language), use it in the request payload, and pass it through to _transcription_to_speech_event so the response language also reflects the correct per-call value. self._language is now only ever mutated by __init__ and update_options.

Fixes #6096

@changeset-bot

changeset-bot Bot commented Jun 14, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ab8a55d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@livekit/agents-plugin-elevenlabs Patch
@livekit/agents Patch
@livekit/agents-plugin-anam Patch
@livekit/agents-plugin-assemblyai Patch
@livekit/agents-plugin-baseten Patch
@livekit/agents-plugin-bey Patch
@livekit/agents-plugin-cartesia Patch
@livekit/agents-plugin-cerebras Patch
@livekit/agents-plugin-deepgram Patch
@livekit/agents-plugin-did Patch
@livekit/agents-plugin-fishaudio Patch
@livekit/agents-plugin-google Patch
@livekit/agents-plugin-hedra Patch
@livekit/agents-plugin-hume Patch
@livekit/agents-plugin-inworld Patch
@livekit/agents-plugin-lemonslice Patch
@livekit/agents-plugin-liveavatar Patch
@livekit/agents-plugin-livekit Patch
@livekit/agents-plugin-minimax Patch
@livekit/agents-plugin-mistral Patch
@livekit/agents-plugin-mistralai Patch
@livekit/agents-plugin-neuphonic Patch
@livekit/agents-plugin-openai Patch
@livekit/agents-plugin-perplexity Patch
@livekit/agents-plugin-phonic Patch
@livekit/agents-plugin-resemble Patch
@livekit/agents-plugin-rime Patch
@livekit/agents-plugin-runway Patch
@livekit/agents-plugin-sarvam Patch
@livekit/agents-plugin-silero Patch
@livekit/agents-plugin-soniox Patch
@livekit/agents-plugin-tavus Patch
@livekit/agents-plugin-trugen Patch
@livekit/agents-plugin-xai Patch
@livekit/agents-plugins-test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@chenghao-mou chenghao-mou merged commit 2cd85da into 1.5.0 Jun 15, 2026
2 checks passed
@chenghao-mou chenghao-mou deleted the moldier-than-drizzled branch June 15, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant