Merged
Conversation
🦋 Changeset detectedLatest commit: 5a48ee5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ben-achilleshr
approved these changes
Apr 24, 2025
|
|
||
| const listenTask = async () => { | ||
| while (!this.closed) { | ||
| while (!this.closed && !closing) { |
Contributor
There was a problem hiding this comment.
JC: was this causing an issue? If so - how did you notice it?
Contributor
Author
There was a problem hiding this comment.
this wasn't causing an issue, i just added this so that when the old websocket closes the loop breaks as opposed to listening indefinitely to new outputs from a closed websocket
Shubhrakanti
approved these changes
Apr 24, 2025
| }; | ||
|
|
||
| await Promise.all([sendTask(), listenTask(), wsMonitor]); | ||
| await Promise.race([this.#resetWS.await, Promise.all([sendTask(), listenTask(), wsMonitor])]); |
Contributor
There was a problem hiding this comment.
Do we propagate exceptions from the underlying tasks? In python we have something like
for task in done:
if task != wait_reconnect_task:
task.result()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.