Skip to content

Fix agent-js to be patch bump#737

Merged
toubatbrian merged 1 commit intomainfrom
brian/fix-pkg-2
Sep 30, 2025
Merged

Fix agent-js to be patch bump#737
toubatbrian merged 1 commit intomainfrom
brian/fix-pkg-2

Conversation

@toubatbrian
Copy link
Copy Markdown
Contributor

@toubatbrian toubatbrian commented Sep 30, 2025

This PR should fix the changeset of accidentally bumping all plugins to major version

% npx changeset status --verbose
🦋  info Packages to be bumped at patch
🦋  - @livekit/agents-plugin-openai 1.0.7
🦋    - .changeset/every-moons-search.md
🦋    - .changeset/yellow-wombats-wait.md
🦋  - @livekit/agents 1.0.7
🦋    - .changeset/yellow-wombats-wait.md
🦋  - @livekit/agents-plugin-cartesia 1.0.7
🦋  - @livekit/agents-plugin-elevenlabs 1.0.7
🦋  - @livekit/agents-plugin-google 1.0.7
🦋  - @livekit/agents-plugin-neuphonic 1.0.7
🦋  - @livekit/agents-plugin-deepgram 1.0.7
🦋  - @livekit/agents-plugin-livekit 1.0.7
🦋  - @livekit/agents-plugin-resemble 1.0.7
🦋  - @livekit/agents-plugin-silero 1.0.7
🦋  - @livekit/agents-plugins-test 1.0.7
🦋  ---
🦋  info Running release would release NO packages as a minor
🦋  ---
🦋  info Packages to be bumped at major
🦋  - @livekit/agents-plugin-rime 1.0.0
🦋    - .changeset/late-eels-wait.md

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Sep 30, 2025

⚠️ No Changeset found

Latest commit: 7222f89

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 12 packages
Name Type
@livekit/agents Patch
@livekit/agents-plugin-openai Patch
@livekit/agents-plugin-cartesia Patch
@livekit/agents-plugin-deepgram Patch
@livekit/agents-plugin-elevenlabs Patch
@livekit/agents-plugin-google Patch
@livekit/agents-plugin-livekit Patch
@livekit/agents-plugin-neuphonic Patch
@livekit/agents-plugin-resemble Patch
@livekit/agents-plugin-rime Patch
@livekit/agents-plugin-silero Patch
@livekit/agents-plugins-test Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -1,5 +1,5 @@
---
'@livekit/agents': minor
'@livekit/agents': patch
Copy link
Copy Markdown
Contributor Author

@toubatbrian toubatbrian Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After changing '@livekit/agents' to be a patch release, all plugins are properly resolved to 1.0.7 (the next patch version). My guess is doing a minor bump on '@livekit/agents' will trigger major bump on plugin packages, which does not make any sense though. cc @lukasIO

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree this doesn't make much sense in our context, here's is an issue report talking about this problem

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changesets/changesets#1011 (comment) oh so it probably right. changeset will bump a major package version if one if its peer dependency has a minor bump.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately yes.

It's probably worth employing the manual dependency patching you linked to until changesets/changesets#1132 is merged

@toubatbrian toubatbrian merged commit c1fe2bc into main Sep 30, 2025
8 checks passed
@toubatbrian toubatbrian deleted the brian/fix-pkg-2 branch September 30, 2025 07:40
@toubatbrian toubatbrian mentioned this pull request Oct 2, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants