(examples revamp): remove redundant files#5523
Conversation
There was a problem hiding this comment.
Devin Review found 1 new potential issue.
🐛 1 issue in files not directly in the diff
🐛 Missing follow_redirects=True in streamable HTTP client causes redirect failures (livekit-agents/livekit/agents/llm/mcp.py:309-312)
The old _create_http_client method (removed in this PR) explicitly set follow_redirects=True when creating the httpx.AsyncClient. The new inline client creation at livekit-agents/livekit/agents/llm/mcp.py:309 omits this parameter, and httpx.AsyncClient defaults to follow_redirects=False. This means any MCP server behind a redirect (common for auth flows, load balancers, CDNs) will fail with the streamable HTTP transport. The old factory was documented as "ported from mcp.shared._httpx_utils.create_mcp_http_client", suggesting redirect support is expected behavior for MCP clients.
View 7 additional findings in Devin Review.
There was a problem hiding this comment.
🔍 Main README description of 'Other' and 'Primitives' directories is now stale
The main examples/README.md (unchanged lines 41–47) still describes other/ as containing "text-only agents, various TTS providers, transcription services, and translation utilities" and primitives/ as covering "participant management, and basic audio/video handling." However, this PR deletes text_only.py, the entire text-to-speech/ directory, transcriber.py, translator.py, participant_entrypoint.py, video-publisher.py, and e2ee.py. After the deletions, other/ contains only cartesia.py, chat-stream-receiver.py, multi-user-transcriber.py, and multi-user-translator.py; primitives/ contains only echo-agent.py and room_stats.py. The descriptions are now misleading. Similarly, examples/other/README.md:3 and examples/primitives/README.md:3 have the same stale descriptions.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
🚩 Phonic plugin README references deleted example
The file livekit-plugins/livekit-plugins-phonic/README.md:77 references voice_agents/phonic_realtime_agent.py which was deleted in this PR. This is a minor external broken reference outside the examples directory.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
🔍 Deleted examples are referenced from the docs site — external link breakage not verifiable here
The new banner at examples/README.md:3 directs users to the LiveKit docs site for examples. If the docs site links back to specific deleted example files in this repo (e.g., avatar_agents/anam/agent_worker.py, voice_agents/weather_agent.py, voice_agents/multi_agent.py), those links would break. This cannot be verified from the repo alone but is worth confirming before merge.
Was this helpful? React with 👍 or 👎 to provide feedback.
| > **Looking for examples and guides?** Most examples now live in the [LiveKit docs](https://docs.livekit.io/agents/). Browse the full collection of runnable examples and recipes on the [Recipes page](https://docs.livekit.io/reference/recipes). | ||
|
|
There was a problem hiding this comment.
🚩 Root README.md has broken links to deleted example files
The root README.md (not part of this diff) contains a showcase table with links to several files deleted in this PR:
README.md:268→examples/voice_agents/background_audio.py(deleted)README.md:275→examples/voice_agents/dynamic_tool_creation.py(deleted)README.md:292→examples/voice_agents/structured_output.py(deleted)README.md:309→examples/other/text_only.py(deleted)README.md:326→examples/avatar_agents/(deleted)README.md:150→examples/voice_agents/multi_agent.py(deleted)
These are now dead links visible on the project's main GitHub page. The root README should be updated as part of this cleanup.
Was this helpful? React with 👍 or 👎 to provide feedback.
these examples will be removed because they are already present in another example or are already in the docs:
./avatar_agents./other/text-to-speechbackground_audio.pyemail_example.pyGetEmailTask()nvidia_test.pybasic_agent.pyrealtime_video_agent.pyrealtime_with_tts.pyweb_search.pysilent_function_call.pyphonic_realtime_agent.pymulti_agent.pyrealtime_turn_detector.pysession_close_callback.pyresume_interrupted_agent.pyrealtime_load_chat_history.pyannotated_tool_args.pytimed_agent_transcript.pyspeedup_output_audio.pyultravox_realtime_api.pydynamic_tool_creation.pyzapier_mcp_integration.pyweather_agent.pybasic_agent.pystructured_output.pytoggle_io.pyspeaker_id_multi_speaker.pyraw_function_description.pyinactive_user.pylanggraph_agent.pylong_running_function.pyminimal_worker.pyelevenlab_scribe_v2.pykokoro_tts.pyopenai.TTS.with_kokoro()?legacy_api.pyvideo-publisher.pytranslator.pyflush_llm_node.pytext_only.pytranscriber.pyparticipant_entrypoint.pye2ee.pyrealtime_joke_teller.pypush_to_talk.pyasync_tool_agent.pyfast-preresponse.pyerror_callback.pylangfuse_trace.pyinstructions_per_modality.pyrestaurant.pytool_search_agent.py