fix(openai): forward session.update on RealtimeModel.update_options#5531
Merged
fix(openai): forward session.update on RealtimeModel.update_options#5531
Conversation
RealtimeSession.update_options() compared against the shared RealtimeModel._opts, but RealtimeModel.update_options() mutated that same dict before forwarding to sessions. The diff always saw "no change" and no session.update was sent. Give each RealtimeSession its own _opts copy so the per-session diff is independent of the model-level state and of any other sessions sharing the same model. Fixes #5530
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
chenghao-mou
approved these changes
Apr 23, 2026
Address review feedback: - Use dataclasses.replace() for the per-session opts copy - Standardize all self._realtime_model._opts reads in RealtimeSession to use the per-session self._opts for consistency
Contributor
|
This is an automated Claude Code Routine created by @toubatbrian. Right now it is in experimentation stage. The automation will start porting this PR into agents-js automatically. Detected classification: plugin fix (OpenAI Realtime). This PR fixes a per-session state diff bug in Generated by Claude Code |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RealtimeSession.update_options()compared against the sharedRealtimeModel._opts, butRealtimeModel.update_options()mutated that same dict before forwarding to sessions. The diff always saw "no change" and nosession.updatewas sent to OpenAI.Give each
RealtimeSessionits own_optscopy so the per-session diff is independent of the model-level state and of any other sessions sharing the same model.Fixes #5530