fix(azure): recover from STT error cancellations instead of hanging#6362
Merged
Merged
Conversation
Azure doesn't always send session_stopped after an error cancel, so the run loop could hang. Wake it and raise so the base retry/fallback takes over.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
longcw
approved these changes
Jul 9, 2026
longcw
left a comment
longcw
left a comment
Contributor
There was a problem hiding this comment.
thanks for the pr! looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If Azure STT hits an error cancellation (like a service timeout), the stream just goes silent.
_on_canceledonly logged a warning, and Azure doesn't reliably sendsession_stoppedafter that, so_runblocks on itsasyncio.waitforever. Audio keeps flowing into a dead recognizer and nothing raises, so retry and fallback never kick in.Now an error cancel records the details and sets the stopped event, so
_runwakes and raisesAPIConnectionError. The base retry loop and FallbackAdapter handle it from there.I kept it on the base retry path instead of adding retry inside the plugin like the earlier attempt (#5333). Happy to flip it if you'd rather.
Tests in
tests/test_plugin_azure_stt.pycover both cases.Fixes #5322