feat(metrics): broadcast llm tps + ttfs + agent_false_interruption#6373
Draft
Bobronium wants to merge 1 commit into
Draft
feat(metrics): broadcast llm tps + ttfs + agent_false_interruption#6373Bobronium wants to merge 1 commit into
Bobronium wants to merge 1 commit into
Conversation
Bobronium
force-pushed
the
arseny/additional-metrics
branch
from
582f129 to
dda4f41
Compare
theomonnom
reviewed
Jul 10, 2026
Comment on lines
+224
to
+232
| async def _set_time_first_sentence() -> None: | ||
| try: | ||
| async for _ in sentence_stream: | ||
| data.ttfs = time.perf_counter() - start_time | ||
| return | ||
| except Exception: | ||
| logger.exception("failed to time first sentence (llm_node_ttfs)") | ||
|
|
||
| ttfs_task = asyncio.create_task(_set_time_first_sentence()) |
Member
There was a problem hiding this comment.
The tokenizer configuration may actually be different than the one being really used. We should try to use the real one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs: livekit/protocol#1661