(google llm): strip thought summaries#6428
Merged
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
davidzhao
approved these changes
Jul 15, 2026
Member
|
exposing as an attribute sounds good. let's do that as a separate one |
theomonnom
reviewed
Jul 15, 2026
| # Drop thought summaries: when include_thoughts is enabled Gemini streams its | ||
| # reasoning back as parts flagged part.thought=True. These must not reach | ||
| # ChoiceDelta.content, otherwise TTS would speak the model's internal reasoning. | ||
| if getattr(part, "thought", None): |
Member
There was a problem hiding this comment.
do we need to use getattr? maybe it's an exposed attribute if we bump their sdk?
theomonnom
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
todo: expose in separate field in chatitem ?