fix(room_io): don't re-fire playback_started on resume - #6636
Merged
Conversation
The first-frame latch tracks a playback segment, so a mid-segment pause/resume must not re-arm it. Resuming a false-interrupted speech announced playback_started a second time, which the transcript synchronizer rejects with a warning: it anchors its clock on the first one and accounts for the pause gap itself.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
…d-resume # Conflicts: # tests/test_room_io.py
davidzhao
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix
_SegmentSynchronizerImpl.on_playback_started called after start_fut is setwarning after resumed false interrupted speech