fix: keep VAD from cancelling a manually committed user turn - #7011
Open
vignesh-koruverse wants to merge 1 commit into
Open
fix: keep VAD from cancelling a manually committed user turn#7011vignesh-koruverse wants to merge 1 commit into
vignesh-koruverse wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7010.
Summary
START_OF_SPEECHno longer cancels the pending end-of-turn task. An eou task in manual mode always belongs to a turn the application already committed._user_turn_committedmakes_on_stt_eventdiscard every later transcript until the next commit.Why
commit_user_turn()resolves after scheduling the end-of-turn bounce, which sleeps the endpointing delay before delivery. Audio tail around a push-to-talk release can raiseSTART_OF_SPEECHinside that window. The cancel is silent: no reply, no log, and the skipped cleanup leaves the session discarding all later transcripts. Same cancellation-poisoning class as #6913 and #6897.Testing
pytest tests/test_audio_recognition_turn_detection.py --audio_eot -q: the two behavior tests fail without the fix and pass with itruff checkandruff format --checkon both changed filesmypy -p livekit.agents.voice.audio_recognition: clean