fix: preserve forkserver copy-on-write sharing - #7120
Merged
Conversation
Freeze forkserver-preloaded Python objects before job processes fork so child GC scans do not make inherited heap pages private. Add regression coverage for preload ordering and child garbage collection. Co-authored-by: Darshak Jankat <darshak.jankat@unifyapps.com>
davidzhao
approved these changes
Sep 4, 2026
chenghao-mou
deleted the
chenghao/fix/AGT-3441-preserve-forkserver-cow
branch
September 4, 2026 19:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Full cyclic GC in a job process writes to inherited GC metadata and turns forkserver-shared heap pages private.
Behavior: Freeze completed preloads before forking. Tests protect ordering and child cycle collection.
Clarification: Use
Shared_Dirtyand PSS, notShared_Clean; the cost varies with preloaded plugins.Credit: Supersedes #7118 by @Darshak03, credited as a commit co-author.
Fixes #7117
Addresses AGT-3441
Initial prompt and agent context
Model: GPT-5.6