Bugfix: Server-initiated room disconnect shutdown fix#205
Merged
Conversation
alan-george-lk
changed the title
Co-authored-by: Cursor <cursoragent@cursor.com>
alan-george-lk
marked this pull request as ready for review
July 13, 2026 22:36
alan-george-lk
requested review from
stephen-derosa and
xianshijing-lk
as code owners
July 13, 2026 22:36
xianshijing-lk
approved these changes
Jul 14, 2026
xianshijing-lk
left a comment
xianshijing-lk
left a comment
Collaborator
There was a problem hiding this comment.
lgtm, assuming you address those comments.
…gfix-room-shutdown
Align the shared cleanup helper with LocalParticipant/FfiClient naming, keep disconnect() returning false for no-ops per its documented contract, and cover Room reuse after server-initiated shutdown. Co-authored-by: Cursor <cursoragent@cursor.com>
alan-george-lk
changed the title
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Collaborator
|
lgtm, thanks |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
alan-george-lk
force-pushed
the
alan/bugfix-room-shutdown
branch
from
July 14, 2026 19:12
3cbddb6 to
a2e6a9e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shutdown()helper, which by proxy cleans up event codeBefore fix, when server deleted the room:
Above observed on Mac, but crashed on Linux (user-reported). No longer after the fix.
Testing
lk --dev room deleteemitFfiEventinto standalone header helperffi_utils.hfor use across two tests nowTicket
BOT-464