Skip to content

Add internal attributes definition helper - #1534

Merged
lukasIO merged 5 commits into
mainfrom
lukas/attr-defs
Jun 2, 2025
Merged

Add internal attributes definition helper#1534
lukasIO merged 5 commits into
mainfrom
lukas/attr-defs

Conversation

@lukasIO

@lukasIO lukasIO commented May 27, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@lukasIO
lukasIO requested review from bcherry and davidzhao May 27, 2025 10:57
@changeset-bot

changeset-bot Bot commented May 27, 2025 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1585507

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented May 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 78.11 KB (-0.01% 🔽)
dist/livekit-client.umd.js 84.07 KB (+0.14% 🔺)

bcherry
bcherry approved these changes May 28, 2025
View reviewed changes
Comment thread src/room/attributes/agent_attr.ts Outdated
@@ -0,0 +1,73 @@
// This file is auto-generated. Do not edit manually.

@bcherry bcherry May 28, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the auto-generation occurs elsewhere, maybe worth updating these comments with a link to it

@lukasIO lukasIO May 29, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, currently restructuring the code gen anyways to support JSON parsing so holding off until that's done

@lukasIO
lukasIO merged commit f12535d into main Jun 2, 2025
@lukasIO
lukasIO deleted the lukas/attr-defs branch June 2, 2025 10:59
svajunas-budrys pushed a commit to svajunas-budrys/client-sdk-js that referenced this pull request Jun 17, 2025
@lukasIO @svajunas-budrys
Add internal attributes definition helper (livekit#1534)
9df2581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcherry bcherry bcherry approved these changes
@davidzhao davidzhao davidzhao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lukasIO @bcherry @davidzhao