fix: add code 1000 to onclose handler in WebSocketStream - #2086
Merged
Conversation
phaitonican
requested review from
1egoman,
lukasIO and
xianshijing-lk
as code owners
September 5, 2026 09:39
🦋 Changeset detectedLatest commit: 4515b19 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Add code 1000 to onclose handler in WebSocketStream.
Contributor
|
This makes sense, thanks for the PR! |
lukasIO
approved these changes
Sep 7, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React Native's WebSocket never sets wasClean (react-native:267), so livekit-client treats every close as unexpected — even the normal code-1000 close that happens on disconnect. On web wasClean is set, so it's silent; on mobile it logs WS closed unexpectedly with code 1000 + error reading from signal stream.