Skip to content

Revert "unlock before returning (#526)"#527

Merged
lukasIO merged 1 commit intomainfrom
lukas/revert-unneeded-unlock
Dec 6, 2022
Merged

Revert "unlock before returning (#526)"#527
lukasIO merged 1 commit intomainfrom
lukas/revert-unneeded-unlock

Conversation

@lukasIO
Copy link
Copy Markdown
Contributor

@lukasIO lukasIO commented Dec 6, 2022

The finally clause will be executed also for the early return.
Unlocking twice doesn't cause any problems, but feels cleaner to just do it once.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Dec 6, 2022

⚠️ No Changeset found

Latest commit: e5e2a7d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lukasIO lukasIO requested a review from davidzhao December 6, 2022 19:03
@lukasIO lukasIO merged commit ed3b30d into main Dec 6, 2022
@lukasIO lukasIO deleted the lukas/revert-unneeded-unlock branch December 6, 2022 19:05
afgarcia86 pushed a commit to afgarcia86/client-sdk-js that referenced this pull request Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants