fix(install): verify release checksum before extracting in install-cli.sh#880
Merged
Merged
Conversation
…i.sh The Linux install script piped the downloaded archive straight into tar with no integrity check. Download the archive and the release's checksums.txt, verify the archive's SHA-256 against the published checksum (failing closed on mismatch), then extract. Guards against corrupted/partial downloads; not a substitute for signature verification against an out-of-band key. Fixes livekit#647
Member
|
Thanks for the fix Gavin! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install-cli.shpiped the downloaded archive straight intotarwith no integritycheck. This downloads the archive and the release's
checksums.txt, verifies thearchive's SHA-256 against the published checksum (failing closed on a missing or
mismatched checksum), then extracts.
Scope / honest caveat
checksums.txtis fetched from the same release over HTTPS, so this guards againstcorrupted/partial downloads and accidental mismatches — it is not a substitute for
signature verification against an out-of-band key. The stronger follow-up would be to
sign
checksums.txt(e.g. cosign/sigstore via goreleaser) and verify the signaturehere.
I'm happy to do that separately if you'd like to enable signing.
Test
Verified against the v2.16.6 release: the checksum parse + match succeeds on the real
archive, and a tampered archive is correctly rejected.
bash -npasses. (The script isLinux-only — it aborts on macOS — so it relies on
sha256sum, with an added presence check.)Fixes #647
Thanks to @xtreme-sameer-vohra for raising it.