Add signal tests to test-server#4653
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
boks1971
left a comment
boks1971
left a comment
There was a problem hiding this comment.
I think signal test is fine.
|
|
||
| func isValidatePath(path string) bool { | ||
| return path == "/rtc/validate" || path == "/rtc/v1/validate" | ||
| } |
There was a problem hiding this comment.
maybe these can use helpers from pkg/service/utils.go. Would be good to have it all in one place for these paths.
There was a problem hiding this comment.
main reason I didn't do it from the start was that the mock currently doesn't depend on the rtc package and we'd be pulling in a bunch of dependencies "just" for the helpers.
Generally agree though that it would be nicer if they were reused.
I'll change it to reuse them from service/utils.go. Let me know if I should extract those helpers into their own package that doesn't pull in the rtc deps
There was a problem hiding this comment.
It is okay to leave this as strings for now. Yeah, don't want to grow the dependency tree. We can address this later.
lukasIO
changed the title
2 participants
Note
closely guided LLM output ahead
Allows for clients to test signal specific connection paths and failures against the test-server. Participant attribute with key
lk.mockdecides on which path to take.Let me know if there are any scenarios missing that might be worth adding.
Not sure if the signal_test.go file is particularly useful, happy to remove if you think there's no additional value in there.