Fix padding bit in forwarded packet. - #4690
Merged
Merged
Conversation
Addresses #4689 We were probably missing a couple of bits with this 1. Not affected for regular traffic like from browsers as it does not add padding, but special clients were affected. 2. Probe packets were probably using wrong last byte as pion/rtp would have overwrriten with 0 because the header.PaddingSize for the newer versions were not set. That could have affected bandwidth estimation catch up.
paulwe
approved these changes
Jul 19, 2026
anunaym14
approved these changes
Jul 19, 2026
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
eleboucher
pushed a commit
to eleboucher/homelab
that referenced
this pull request
Jul 31, 2026
…4 ➔ v1.13.5) (#1778) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [docker.io/livekit/livekit-server](https://github.com/livekit/livekit) | patch | `v1.13.4` → `v1.13.5` | --- >⚠️ **Warning** > > Some dependencies could not be looked up. Check the [Dependency Dashboard](issues/567) for more information. --- ### Release Notes <details> <summary>livekit/livekit (docker.io/livekit/livekit-server)</summary> ### [`v1.13.5`](https://github.com/livekit/livekit/releases/tag/v1.13.5) [Compare Source](livekit/livekit@v1.13.4...v1.13.5) ##### Added - add mock for testing region pins with API ([#​4691](livekit/livekit#4691)) - Add country to participant closing log ([#​4693](livekit/livekit#4693)) - Tests for down stream packet push. ([#​4692](livekit/livekit#4692)) - Add status code for twirp request latency prometheus metric ([#​4621](livekit/livekit#4621)) - Support more h264 profiles ([#​4708](livekit/livekit#4708)) - log high stream start latency. ([#​4714](livekit/livekit#4714)) ##### Changed - Use simulcast constructor for VP9 if simulcasted. ([#​4696](livekit/livekit#4696)) - send resolved ringing timeout ([#​4697](livekit/livekit#4697)) - Update go deps ([#​4645](livekit/livekit#4645)) - protocol deps for logging webhook status ([#​4699](livekit/livekit#4699)) - protocol update with webhook status logging ([#​4700](livekit/livekit#4700)) - Record subscribe stream start time in prometheus. ([#​4704](livekit/livekit#4704)) - A bit better counting for track publish. ([#​4707](livekit/livekit#4707)) ##### Fixed - Fix padding bit in forwarded packet. ([#​4690](livekit/livekit#4690)) - Spelling fixes ([#​4698](livekit/livekit#4698)) - Do not call telemetry listener under pending track lock. ([#​4706](livekit/livekit#4706)) - Fix getRefLayerRTPTimestamp off-by-one that can panic on max layer index ([#​4712](livekit/livekit#4712)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDEuMSIsInVwZGF0ZWRJblZlciI6IjQzLjEwMS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL3BhdGNoIl19--> Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/1778
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #4689
We were probably missing a couple of bits with this