agent simulation: enrich Turn metrics#1673
Merged
Merged
Conversation
theomonnom
reviewed
Jul 20, 2026
| optional uint32 agent_reported_e2e_latency_ms = 6; | ||
| // persona rows: agent audio continuing past this turn's start; set iff the turn barged in | ||
| optional uint32 agent_yield_latency_ms = 7; | ||
| repeated string flags = 8; // judge failure tags ("verbosity_or_filler", ...) |
Member
There was a problem hiding this comment.
it's unclear what the flags could be, is it on purpose?
Member
Author
There was a problem hiding this comment.
The field was intended to carry information about the turn such as "barge_in", "unanswered". "eot_misprediction", "awkward_silence". Comment was stale by the time of the PR.
Now with conversation message included (it contains dedicated fields for this), it's redundant and removed.
theomonnom
approved these changes
Jul 20, 2026
🦋 Changeset detectedLatest commit: 2abd1c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Bobronium
marked this pull request as ready for review
July 21, 2026 08:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homogenizes Turn/Job/Run LLM/TTS/STT shapes