add support for RPC interceptors - #806
Open
davidzhao wants to merge 4 commits into
Open
Conversation
allowing telemetry hooks so we can provide automatic traces when used in agents.
davidzhao
requested review from
cloudwebrtc,
lukasIO and
xianshijing-lk
as code owners
September 5, 2026 16:21
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…identity Review follow-ups on the interceptor hook: - The caller's response_timeout now covers the whole incoming chain (_run_incoming_chain wraps interceptors + handler in one wait_for), so time an interceptor spends before or after next() counts against it instead of handing the handler a fresh full timeout. Deadline expiry cancels the chain and maps to RESPONSE_TIMEOUT; cancellation from outside (room disconnect) still maps to RECIPIENT_DISCONNECTED. _invoke_rpc_handler no longer wraps the handler itself. - add_rpc_interceptor / remove_rpc_interceptor compare by identity, so two distinct interceptors that compare equal coexist and only the exact instance is removed. - mypy: cast the awaited handler result; fix the non-overlapping identity check in the test. Tests: deadline burned before and after next(), outside cancellation, identity registration; the timeout test now asserts interceptors observe the cancellation. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
asyncio.wait_for raises the same TimeoutError a handler or interceptor might raise on its own (an HTTP client timing out, say), so _run_incoming_chain reported both as RESPONSE_TIMEOUT. The pre-existing handler wrapper had the same conflation, but now that the deadline spans the chain it is cheap to get right: a TimeoutError raised inside the chain is tagged (_ChainTimeoutError) and re-raised as the original exception, which _handle_rpc_method_invocation maps to APPLICATION_ERROR like any other handler failure; only wait_for's own expiry becomes RESPONSE_TIMEOUT. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…ng error wait_for reported whatever the chain raised while being cancelled; an interceptor that catches the cancellation and raises during cleanup could turn a deadline expiry into APPLICATION_ERROR (or, via the TimeoutError tag, back into a mislabelled application timeout). The chain now runs as its own future under a call_later deadline that sets a flag before cancelling it. Once the flag is set, anything the chain raises while unwinding is reported as RESPONSE_TIMEOUT; a CancelledError without the flag is external cancellation and stays RECIPIENT_DISCONNECTED; any exception before the deadline, TimeoutError included, propagates as an application error. The _ChainTimeoutError tag is no longer needed. Tests: cleanup raising TimeoutError and RuntimeError after the deadline both map to RESPONSE_TIMEOUT; the existing deadline, in-chain timeout and outside cancellation cases still hold. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allowing telemetry hooks so we can provide automatic traces when used in agents.