fix: don't fire local_track_subscribed during reconnect#1099
Merged
Conversation
During a full reconnect, the engine auto-resubscribes the republished local tracks under their new server-issued SIDs. Forwarding this event would race with the sid rekey driven by `LocalTrackRepublished` (different task, same dispatcher channel) and surface as a KeyError / already-resolved future on the binding side.
davidzhao
requested review from
MaxHeimbrock,
alan-george-lk,
stephen-derosa and
xianshijing-lk
as code owners
Contributor
ChangesetThe following package versions will be affected by this PR:
|
Member
|
For this fix, I'm wondering if it should be inside the rtc_engine vs inside the ffi? |
ladvoc
pushed a commit
that referenced
this pull request
May 18, 2026
> [!IMPORTANT] > Merging this pull request will create these releases # livekit-datatrack 0.1.6 (2026-05-18) ## Fixes - Add AGENTS.md and minor doc revisions - Add `cargo-fuzz` target for packet deserialization # webrtc-sys-build 0.3.17 (2026-05-18) ## Fixes - fix libwebrtc cache permissions and optimize CI test workflows - #1071 (@davidzhao) # livekit-api 0.4.23 (2026-05-18) ## Fixes - Expose room playout delay options in the server API and let the local video publisher recreate rooms with explicit min/max playout delay settings. # livekit-ffi 0.12.58 (2026-05-18) ## Features - FFI logging improvements ### Make `sample_rate` and `num_channels` optional in `NewAudioSourceRequest`. These fields are ignored for `AudioSourcePlatform` (ADM uses hardware native settings) and for `AudioSourceNative` fast path (queue_size_ms=0, frame values used directly). Defaults to 48000 Hz and 1 channel when not specified. ## Fixes - fix: don't fire local_track_subscribed during reconnect - #1099 (@davidzhao) - Fix LocalTrackPublished handle leak - #1065 (@MaxHeimbrock) - Return EOS event from data track stream read request Co-authored-by: knope-bot[bot] <152252888+knope-bot[bot]@users.noreply.github.com>
Member
Author
what is this event used for by local clients? I know that FFI clients def don't need it.. because the handle is abstracted away locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During a full reconnect, the engine auto-resubscribes the republished local tracks under their new server-issued SIDs. Forwarding this event would race with the sid rekey driven by
LocalTrackRepublished(different task, same dispatcher channel) and surface as a KeyError / already-resolved future on the binding side.