Skip to content

Add support for swapping out the HTTP Client #487

Closed
mikayla-maki wants to merge 6 commits into
livekit:mainfrom
zed-industries:http-client-dispatcher
Closed

Add support for swapping out the HTTP Client #487
mikayla-maki wants to merge 6 commits into
livekit:mainfrom
zed-industries:http-client-dispatcher

Conversation

@mikayla-maki
Copy link
Copy Markdown
Contributor

@mikayla-maki mikayla-maki commented Nov 15, 2024

This PR updates the http_client to follow the dispatcher pattern.

@mikayla-maki mikayla-maki force-pushed the http-client-dispatcher branch from 46c1ca1 to 1f8eed2 Compare December 2, 2024 18:31
@mikayla-maki
Copy link
Copy Markdown
Contributor Author

Note that the dispatcher feature we use here was broken by the inclusion of "tokio" as a default runtime feature in: #495 combined with cargo always including default features from: #483

However, after fixing those bugs the livekit-runtime crate's default features are still being included. Haven't quite figured out why yet...

@mikayla-maki
Copy link
Copy Markdown
Contributor Author

We no longer need this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants