Skip to content

fix: Doc.rs Build Fails For livekit-api = 0.4.1#495

Merged
theomonnom merged 17 commits into
livekit:mainfrom
tommady:fix-492
Nov 30, 2024
Merged

fix: Doc.rs Build Fails For livekit-api = 0.4.1#495
theomonnom merged 17 commits into
livekit:mainfrom
tommady:fix-492

Conversation

@tommady
Copy link
Copy Markdown
Contributor

@tommady tommady commented Nov 27, 2024

fix and close: #492

Signed-off-by: tommady <tommady@users.noreply.github.com>
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 27, 2024

CLA assistant check
All committers have signed the CLA.

Signed-off-by: tommady <tommady@users.noreply.github.com>
Signed-off-by: tommady <tommady@users.noreply.github.com>
Signed-off-by: tommady <tommady@users.noreply.github.com>
Signed-off-by: tommady <tommady@users.noreply.github.com>
Signed-off-by: tommady <tommady@users.noreply.github.com>
…t import

Signed-off-by: tommady <tommady@users.noreply.github.com>
Signed-off-by: tommady <tommady@users.noreply.github.com>
Signed-off-by: tommady <tommady@users.noreply.github.com>
Signed-off-by: tommady <tommady@users.noreply.github.com>
Signed-off-by: tommady <tommady@users.noreply.github.com>
Signed-off-by: tommady <tommady@users.noreply.github.com>
Signed-off-by: tommady <tommady@users.noreply.github.com>
Signed-off-by: tommady <tommady@users.noreply.github.com>
Signed-off-by: tommady <tommady@users.noreply.github.com>
Signed-off-by: tommady <tommady@users.noreply.github.com>
Signed-off-by: tommady <tommady@users.noreply.github.com>
@tommady
Copy link
Copy Markdown
Contributor Author

tommady commented Nov 27, 2024

@nbsp, could someone kindly assist me with the review?

I’ve made the following fixes:

  1. cargo doc
  2. CI tests

However, I’m uncertain if these modifications fully meet your expectations.
Please provide your guidance. 🙇🏻

@nbsp nbsp requested review from nbsp and theomonnom November 27, 2024 13:53
Copy link
Copy Markdown
Contributor

@cloudwebrtc cloudwebrtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@theomonnom theomonnom merged commit 9d68b19 into livekit:main Nov 30, 2024
@tommady tommady deleted the fix-492 branch December 2, 2024 01:49
mikayla-maki pushed a commit to zed-industries/livekit-rust-sdks that referenced this pull request Dec 2, 2024
mikayla-maki pushed a commit to zed-industries/livekit-rust-sdks that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doc.rs Build Fails For livekit-api = "0.4.1"

4 participants