ci: Fix wonky FFI builds#501
Conversation
The FFI builds have been failing due to the WebRTC license file not existing. Since that file is only generated when compiling to Android as a target, this PR ensures the file exists in that location, and swaps double quotation marks for single ones.
|
|
|
Could you take a look at this PR? I believe it might be the root cause, but I’m curious why this .gitignore was added to exclude the LICENSE file. |
| cat LICENSE >> TEMP_LICENSE.md | ||
| echo "```" >> TEMP_LICENSE.md | ||
| echo '```' >> TEMP_LICENSE.md | ||
| touch livekit-ffi/WEBRTC_LICENSE.md |
There was a problem hiding this comment.
Regarding my comment about the .gitignore excluding the LICENSE file, simply creating an empty LICENSE file doesn’t seem like a good solution.
There was a problem hiding this comment.
Fair enough. I chose this route since, as seen here, the file is only generated when the target is an Android device. Maybe a better alternative would be running this job when an Android target matches.
|
This file should be generated for each platform: rust-sdks/webrtc-sys/libwebrtc/build_linux.sh Line 126 in fb1efb0 |
|
I think the issue is coming from this PR #495 |
|
Ah, I see now—thank you for taking the time to explain. Just to confirm, is the CI issue related to correctly addressing the $ARTIFACTS_DIR? If so, I stand by my review: creating an empty LICENSE file doesn’t effectively address the core issue. 🙇🏻♂️ By the way, regarding the PR you mentioned (#495), I want to clarify that I didn’t make any changes to the build_linux.sh file. In that PR, I explicitly stated that my intent was to resolve the issues with the cargo doc build and the CI tests. |
4 participants
The FFI builds have been failing due to the WebRTC license file not existing. Since that file is only generated when compiling to Android as a target, this PR ensures the file exists in that location, and swaps double quotation marks for single ones.